From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-kselftest@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Reinette Chatre <reinette.chatre@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH 3/4] selftests/resctrl: Change name from CBM_MASK_PATH to INFO_PATH
Date: Wed, 8 Feb 2023 16:04:27 +0200 (EET) [thread overview]
Message-ID: <2078baac-27ea-096-3a13-b88fe10aa78@linux.intel.com> (raw)
In-Reply-To: <20230208094026.22529-4-ilpo.jarvinen@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1753 bytes --]
On Wed, 8 Feb 2023, Ilpo Järvinen wrote:
> From: "Signed-off-by: Fenghua Yu" <fenghua.yu@intel.com>
I seem to have managed to do a little copy paste error there. I can
resubmit the series if needed.
--
i.
> CBM_MASK_PATH is actually the path to resctrl/info, so change the macro
> name to correctly indicate what it represents.
>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> ---
> tools/testing/selftests/resctrl/resctrl.h | 2 +-
> tools/testing/selftests/resctrl/resctrlfs.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/selftests/resctrl/resctrl.h
> index f0ded31fb3c7..4f0976f12634 100644
> --- a/tools/testing/selftests/resctrl/resctrl.h
> +++ b/tools/testing/selftests/resctrl/resctrl.h
> @@ -28,7 +28,7 @@
> #define MB (1024 * 1024)
> #define RESCTRL_PATH "/sys/fs/resctrl"
> #define PHYS_ID_PATH "/sys/devices/system/cpu/cpu"
> -#define CBM_MASK_PATH "/sys/fs/resctrl/info"
> +#define INFO_PATH "/sys/fs/resctrl/info"
> #define L3_PATH "/sys/fs/resctrl/info/L3"
> #define MB_PATH "/sys/fs/resctrl/info/MB"
> #define L3_MON_PATH "/sys/fs/resctrl/info/L3_MON"
> diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c
> index 6f543e470ad4..cc6cf49e3129 100644
> --- a/tools/testing/selftests/resctrl/resctrlfs.c
> +++ b/tools/testing/selftests/resctrl/resctrlfs.c
> @@ -210,7 +210,7 @@ int get_cbm_mask(char *cache_type, char *cbm_mask)
> if (!cbm_mask)
> return -1;
>
> - sprintf(cbm_mask_path, "%s/%s/cbm_mask", CBM_MASK_PATH, cache_type);
> + sprintf(cbm_mask_path, "%s/%s/cbm_mask", INFO_PATH, cache_type);
>
> fp = fopen(cbm_mask_path, "r");
> if (!fp) {
>
next prev parent reply other threads:[~2023-02-08 14:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 9:40 [PATCH 0/4] selftests/resctrl: Small cleanups Ilpo Järvinen
2023-02-08 9:40 ` [PATCH 1/4] selftests/resctrl: Change initialize_llc_perf() return type to void Ilpo Järvinen
2023-02-14 0:59 ` Reinette Chatre
2023-02-08 9:40 ` [PATCH 2/4] selftests/resctrl: Don't hard code divisor in MBM results Ilpo Järvinen
2023-02-14 0:59 ` Reinette Chatre
2023-02-14 10:00 ` Ilpo Järvinen
2023-02-14 17:01 ` Reinette Chatre
2023-02-08 9:40 ` [PATCH 3/4] selftests/resctrl: Change name from CBM_MASK_PATH to INFO_PATH Ilpo Järvinen
2023-02-08 14:04 ` Ilpo Järvinen [this message]
2023-02-14 0:59 ` Reinette Chatre
2023-02-08 9:40 ` [PATCH 4/4] selftests/resctrl: Use remount_resctrlfs() consistently with boolean Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2078baac-27ea-096-3a13-b88fe10aa78@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox