public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: KP Singh <kpsingh@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: pjt@google.com, evn@google.com, jpoimboe@kernel.org,
	tglx@linutronix.de, x86@kernel.org, hpa@zytor.com,
	peterz@infradead.org, pawan.kumar.gupta@linux.intel.com,
	kim.phillips@amd.com, alexandre.chartre@oracle.com,
	daniel.sneddon@linux.intel.com, corbet@lwn.net, bp@suse.de,
	linyujun809@huawei.com, kpsingh@kernel.org, jmattson@google.com
Subject: [PATCH v2 2/2] Documentation/hw-vuln: Document the interaction between IBRS and STIBP
Date: Tue, 21 Feb 2023 19:49:08 +0100	[thread overview]
Message-ID: <20230221184908.2349578-2-kpsingh@kernel.org> (raw)
In-Reply-To: <20230221184908.2349578-1-kpsingh@kernel.org>

Explain why STIBP is needed with legacy IBRS as currently implemented
(KERNEL_IBRS) and why STIBP is not needed when enhanced IBRS is enabled.

Signed-off-by: KP Singh <kpsingh@kernel.org>
---
 Documentation/admin-guide/hw-vuln/spectre.rst | 22 ++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/Documentation/admin-guide/hw-vuln/spectre.rst b/Documentation/admin-guide/hw-vuln/spectre.rst
index c4dcdb3d0d45..e193ee13dc9a 100644
--- a/Documentation/admin-guide/hw-vuln/spectre.rst
+++ b/Documentation/admin-guide/hw-vuln/spectre.rst
@@ -479,8 +479,17 @@ Spectre variant 2
    On Intel Skylake-era systems the mitigation covers most, but not all,
    cases. See :ref:`[3] <spec_ref3>` for more details.
 
-   On CPUs with hardware mitigation for Spectre variant 2 (e.g. Enhanced
-   IBRS on x86), retpoline is automatically disabled at run time.
+   On CPUs with hardware mitigation for Spectre variant 2 (e.g. IBRS
+   or enhanced IBRS on x86), retpoline is automatically disabled at run time.
+
+   Setting the IBRS bit implicitly enables STIBP which guards against
+   cross-thread branch target injection on SMT systems. On systems with enhanced
+   IBRS, the kernel sets the bit once, which keeps cross-thread protections
+   always enabled, obviating the need for an explicit STIBP. On CPUs with legacy
+   IBRS, the kernel clears the IBRS bit on returning to user-space, thus also
+   disabling the implicit STIBP. Consequently, STIBP needs to be explicitly
+   enabled to guard against cross-thread attacks in userspace.
+
 
    The retpoline mitigation is turned on by default on vulnerable
    CPUs. It can be forced on or off by the administrator
@@ -504,9 +513,12 @@ Spectre variant 2
    For Spectre variant 2 mitigation, individual user programs
    can be compiled with return trampolines for indirect branches.
    This protects them from consuming poisoned entries in the branch
-   target buffer left by malicious software.  Alternatively, the
-   programs can disable their indirect branch speculation via prctl()
-   (See :ref:`Documentation/userspace-api/spec_ctrl.rst <set_spec_ctrl>`).
+   target buffer left by malicious software.
+
+   On legacy IBRS systems, at return to userspace, implicit STIBP is disabled
+   because the kernel clears the IBRS bit. In this case, the userspace programs
+   can disable indirect branch speculation via prctl() (See
+   :ref:`Documentation/userspace-api/spec_ctrl.rst <set_spec_ctrl>`).
    On x86, this will turn on STIBP to guard against attacks from the
    sibling thread when the user program is running, and use IBPB to
    flush the branch target buffer when switching to/from the program.
-- 
2.39.2.637.g21b0678d19-goog


  reply	other threads:[~2023-02-21 18:49 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 18:49 [PATCH v2 1/2] x86/speculation: Allow enabling STIBP with legacy IBRS KP Singh
2023-02-21 18:49 ` KP Singh [this message]
2023-02-23 14:52   ` [PATCH v2 2/2] Documentation/hw-vuln: Document the interaction between IBRS and STIBP Borislav Petkov
2023-02-24  3:30     ` KP Singh
2023-02-26  1:42     ` KP Singh
2023-02-21 19:29 ` [PATCH v2 1/2] x86/speculation: Allow enabling STIBP with legacy IBRS Greg KH
2023-02-21 19:29 ` Greg KH
2023-02-21 19:35   ` KP Singh
2023-02-21 19:47     ` Greg KH
2023-02-21 19:57       ` Borislav Petkov
2023-02-21 20:09         ` Greg KH
2023-02-21 20:23           ` Borislav Petkov
2023-02-22  3:07 ` Pawan Gupta
2023-02-22  5:49   ` KP Singh
2023-02-22  8:25     ` Pawan Gupta
2023-02-22 12:32     ` Borislav Petkov
2023-02-22 13:56       ` David Laight
2023-02-22 12:24 ` Borislav Petkov
2023-02-22 17:16   ` KP Singh
2023-02-22 17:48     ` Borislav Petkov
2023-02-22 19:41       ` KP Singh
2023-02-23 12:44         ` Borislav Petkov
2023-02-26  1:50           ` KP Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230221184908.2349578-2-kpsingh@kernel.org \
    --to=kpsingh@kernel.org \
    --cc=alexandre.chartre@oracle.com \
    --cc=bp@suse.de \
    --cc=corbet@lwn.net \
    --cc=daniel.sneddon@linux.intel.com \
    --cc=evn@google.com \
    --cc=hpa@zytor.com \
    --cc=jmattson@google.com \
    --cc=jpoimboe@kernel.org \
    --cc=kim.phillips@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linyujun809@huawei.com \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox