[PATCH] ASoC: SMA1303: set sma_i2c_regmap storage-class-specifier to static

[PATCH] ASoC: SMA1303: set sma_i2c_regmap storage-class-specifier to static

[Tom Rix]

smatch reports
sound/soc/codecs/sma1303.c:1594:28:
  warning: symbol 'sma_i2c_regmap' was not declared. Should it be static?

sma_i2c_regmap is only used in sma1303, so it should be static

Signed-off-by: Tom Rix <trix@redhat.com>
---
 sound/soc/codecs/sma1303.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/sma1303.c b/sound/soc/codecs/sma1303.c
index fa4b0a60f8a9..b6c132edf3bd 100644
--- a/sound/soc/codecs/sma1303.c
+++ b/sound/soc/codecs/sma1303.c
@@ -1591,7 +1591,7 @@ static const struct snd_soc_component_driver sma1303_component = {
 	.num_dapm_routes = ARRAY_SIZE(sma1303_audio_map),
 };
 
-const struct regmap_config sma_i2c_regmap = {
+static const struct regmap_config sma_i2c_regmap = {
 	.reg_bits = 8,
 	.val_bits = 8,
 
-- 
2.27.0

Re: [PATCH] ASoC: SMA1303: set sma_i2c_regmap storage-class-specifier to static

[Mark Brown]

On Thu, 09 Mar 2023 09:09:59 -0500, Tom Rix wrote:
> smatch reports
> sound/soc/codecs/sma1303.c:1594:28:
>   warning: symbol 'sma_i2c_regmap' was not declared. Should it be static?
> 
> sma_i2c_regmap is only used in sma1303, so it should be static
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SMA1303: set sma_i2c_regmap storage-class-specifier to static
      commit: d7d103d1779c3d0bc4d55f2802930a6b067450c0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark