public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>,
	Andi Shyti <andi.shyti@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	lvc-project@linuxtesting.org,
	Kasumov Ruslan <xhxgldhlpfy@gmail.com>,
	linux-arm-msm@vger.kernel.org,
	Bjorn Andersson <andersson@kernel.org>,
	linux-kernel@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	linux-iio@vger.kernel.org, Andy Gross <agross@kernel.org>,
	Kasumov Ruslan <s02210418@gse.cs.msu.ru>,
	Jonathan Cameron <jic23@kernel.org>
Subject: Re: [lvc-project] [PATCH] iio: adc: qcom-pm8xxx-xoadc: Remove useless condition in pm8xxx_xoadc_parse_channel()
Date: Tue, 14 Mar 2023 23:41:54 +0100	[thread overview]
Message-ID: <20230314224154.7gctfkt2mlaz3geg@intel.intel> (raw)
In-Reply-To: <CACRpkdb2CFckKo=VGb4gkyS0pXmqDrRBtJNeT1PjetctRquBVQ@mail.gmail.com>

Hi Alexey and Ruslan,

On Tue, Mar 14, 2023 at 11:07:19PM +0100, Linus Walleij wrote:
> On Tue, Mar 14, 2023 at 11:03 PM Alexey Khoroshilov
> <khoroshilov@ispras.ru> wrote:
> 
> > As far as I can see sentinel is an "empty" element of xoadc_channel in
> > the array, i.e. hwchan->datasheet_name works as a sentinel while hwchan
> > is always non NULL.
> 
> You're right, I was unable to understand my own code :(

At this time of the day I got alarmed too. Happens :)

Please ignore my previous comment but still no need for the
Fixes: tag from the commit log as it's a cleanup and not a bug
fix.

Thanks,
Andi

  reply	other threads:[~2023-03-14 22:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 19:37 [PATCH] iio: adc: qcom-pm8xxx-xoadc: Remove useless condition in pm8xxx_xoadc_parse_channel() Kasumov Ruslan
2023-03-14 20:42 ` Andi Shyti
2023-03-14 21:12 ` Linus Walleij
2023-03-14 21:28   ` Andi Shyti
2023-03-14 22:03     ` [lvc-project] " Alexey Khoroshilov
2023-03-14 22:07       ` Linus Walleij
2023-03-14 22:41         ` Andi Shyti [this message]
2023-03-14 22:04   ` Linus Walleij
2023-03-14 22:16 ` Linus Walleij
2023-03-15 13:51 ` [PATCH v2] " Kasumov Ruslan
2023-03-18 15:48   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230314224154.7gctfkt2mlaz3geg@intel.intel \
    --to=andi.shyti@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=jic23@kernel.org \
    --cc=khoroshilov@ispras.ru \
    --cc=konrad.dybcio@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=s02210418@gse.cs.msu.ru \
    --cc=xhxgldhlpfy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox