* [PATCH] tpm: cr50: i2c: use jiffies to wait for tpm ready irq
@ 2023-03-14 19:54 Mark Hasemeyer
2023-03-19 13:36 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Mark Hasemeyer @ 2023-03-14 19:54 UTC (permalink / raw)
To: Jarkko Sakkinen
Cc: Mark Hasemeyer, Jason Gunthorpe, Peter Huewe, linux-integrity,
linux-kernel
When waiting for a tpm ready completion, the cr50 i2c driver incorrectly
assumes that the value of timeout_a is represented in milliseconds
instead of jiffies.
Remove the msecs_to_jiffies conversion.
Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
---
drivers/char/tpm/tpm_tis_i2c_cr50.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis_i2c_cr50.c b/drivers/char/tpm/tpm_tis_i2c_cr50.c
index 77cea5b31c6e4..376ae18a04ebb 100644
--- a/drivers/char/tpm/tpm_tis_i2c_cr50.c
+++ b/drivers/char/tpm/tpm_tis_i2c_cr50.c
@@ -100,8 +100,7 @@ static int tpm_cr50_i2c_wait_tpm_ready(struct tpm_chip *chip)
}
/* Wait for interrupt to indicate TPM is ready to respond */
- if (!wait_for_completion_timeout(&priv->tpm_ready,
- msecs_to_jiffies(chip->timeout_a))) {
+ if (!wait_for_completion_timeout(&priv->tpm_ready, chip->timeout_a)) {
dev_warn(&chip->dev, "Timeout waiting for TPM ready\n");
return -ETIMEDOUT;
}
--
2.40.0.rc2.332.ga46443480c-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tpm: cr50: i2c: use jiffies to wait for tpm ready irq
2023-03-14 19:54 [PATCH] tpm: cr50: i2c: use jiffies to wait for tpm ready irq Mark Hasemeyer
@ 2023-03-19 13:36 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2023-03-19 13:36 UTC (permalink / raw)
To: Mark Hasemeyer
Cc: Jason Gunthorpe, Peter Huewe, linux-integrity, linux-kernel
On Tue, Mar 14, 2023 at 01:54:04PM -0600, Mark Hasemeyer wrote:
> When waiting for a tpm ready completion, the cr50 i2c driver incorrectly
> assumes that the value of timeout_a is represented in milliseconds
> instead of jiffies.
>
> Remove the msecs_to_jiffies conversion.
>
> Signed-off-by: Mark Hasemeyer <markhas@chromium.org>
> ---
>
> drivers/char/tpm/tpm_tis_i2c_cr50.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_tis_i2c_cr50.c b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> index 77cea5b31c6e4..376ae18a04ebb 100644
> --- a/drivers/char/tpm/tpm_tis_i2c_cr50.c
> +++ b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> @@ -100,8 +100,7 @@ static int tpm_cr50_i2c_wait_tpm_ready(struct tpm_chip *chip)
> }
>
> /* Wait for interrupt to indicate TPM is ready to respond */
> - if (!wait_for_completion_timeout(&priv->tpm_ready,
> - msecs_to_jiffies(chip->timeout_a))) {
> + if (!wait_for_completion_timeout(&priv->tpm_ready, chip->timeout_a)) {
> dev_warn(&chip->dev, "Timeout waiting for TPM ready\n");
> return -ETIMEDOUT;
> }
> --
> 2.40.0.rc2.332.ga46443480c-goog
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-19 13:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-14 19:54 [PATCH] tpm: cr50: i2c: use jiffies to wait for tpm ready irq Mark Hasemeyer
2023-03-19 13:36 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox