* [PATCH] firmware: qcom_scm: Add SM6375 compatible
@ 2023-03-07 1:22 Konrad Dybcio
2023-03-07 13:13 ` Konrad Dybcio
2023-03-22 14:45 ` Bjorn Andersson
0 siblings, 2 replies; 4+ messages in thread
From: Konrad Dybcio @ 2023-03-07 1:22 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross
Cc: marijn.suijten, Konrad Dybcio, linux-kernel
While it was introduced in bindings, requiring a core clock, and added
into the DT, this compatible was apparently forgotten about on the driver
side of things. Fix it.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
drivers/firmware/qcom_scm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
index 916a0c2fc903..2e8961c84b68 100644
--- a/drivers/firmware/qcom_scm.c
+++ b/drivers/firmware/qcom_scm.c
@@ -1494,6 +1494,7 @@ static const struct of_device_id qcom_scm_dt_match[] = {
},
{ .compatible = "qcom,scm-msm8994" },
{ .compatible = "qcom,scm-msm8996" },
+ { .compatible = "qcom,scm-sm6375", .data = (void *)SCM_HAS_CORE_CLK },
{ .compatible = "qcom,scm" },
{}
};
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] firmware: qcom_scm: Add SM6375 compatible
2023-03-07 1:22 [PATCH] firmware: qcom_scm: Add SM6375 compatible Konrad Dybcio
@ 2023-03-07 13:13 ` Konrad Dybcio
2023-03-22 3:36 ` Bjorn Andersson
2023-03-22 14:45 ` Bjorn Andersson
1 sibling, 1 reply; 4+ messages in thread
From: Konrad Dybcio @ 2023-03-07 13:13 UTC (permalink / raw)
To: linux-arm-msm, andersson, agross; +Cc: marijn.suijten, linux-kernel
On 7.03.2023 02:22, Konrad Dybcio wrote:
> While it was introduced in bindings, requiring a core clock, and added
> into the DT, this compatible was apparently forgotten about on the driver
> side of things. Fix it.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> drivers/firmware/qcom_scm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index 916a0c2fc903..2e8961c84b68 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -1494,6 +1494,7 @@ static const struct of_device_id qcom_scm_dt_match[] = {
> },
> { .compatible = "qcom,scm-msm8994" },
> { .compatible = "qcom,scm-msm8996" },
> + { .compatible = "qcom,scm-sm6375", .data = (void *)SCM_HAS_CORE_CLK },
On a second thought, maybe the qcom,scm compatible could optionally consume
all three clocks with schema guarding how many should be used, to prevent
having to add nonsensical compatibles?
Konrad
> { .compatible = "qcom,scm" },
> {}
> };
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] firmware: qcom_scm: Add SM6375 compatible
2023-03-07 13:13 ` Konrad Dybcio
@ 2023-03-22 3:36 ` Bjorn Andersson
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-03-22 3:36 UTC (permalink / raw)
To: Konrad Dybcio; +Cc: linux-arm-msm, agross, marijn.suijten, linux-kernel
On Tue, Mar 07, 2023 at 02:13:53PM +0100, Konrad Dybcio wrote:
>
>
> On 7.03.2023 02:22, Konrad Dybcio wrote:
> > While it was introduced in bindings, requiring a core clock, and added
> > into the DT, this compatible was apparently forgotten about on the driver
> > side of things. Fix it.
> >
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> > ---
> > drivers/firmware/qcom_scm.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> > index 916a0c2fc903..2e8961c84b68 100644
> > --- a/drivers/firmware/qcom_scm.c
> > +++ b/drivers/firmware/qcom_scm.c
> > @@ -1494,6 +1494,7 @@ static const struct of_device_id qcom_scm_dt_match[] = {
> > },
> > { .compatible = "qcom,scm-msm8994" },
> > { .compatible = "qcom,scm-msm8996" },
> > + { .compatible = "qcom,scm-sm6375", .data = (void *)SCM_HAS_CORE_CLK },
> On a second thought, maybe the qcom,scm compatible could optionally consume
> all three clocks with schema guarding how many should be used, to prevent
> having to add nonsensical compatibles?
>
I've picked the patch, but your suggestion is not a bad idea. Back when
this scheme was decided there was no binding validation...
Regards,
Bjorn
> Konrad
> > { .compatible = "qcom,scm" },
> > {}
> > };
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] firmware: qcom_scm: Add SM6375 compatible
2023-03-07 1:22 [PATCH] firmware: qcom_scm: Add SM6375 compatible Konrad Dybcio
2023-03-07 13:13 ` Konrad Dybcio
@ 2023-03-22 14:45 ` Bjorn Andersson
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-03-22 14:45 UTC (permalink / raw)
To: agross, linux-arm-msm, Konrad Dybcio; +Cc: marijn.suijten, linux-kernel
On Tue, 7 Mar 2023 02:22:47 +0100, Konrad Dybcio wrote:
> While it was introduced in bindings, requiring a core clock, and added
> into the DT, this compatible was apparently forgotten about on the driver
> side of things. Fix it.
>
>
Applied, thanks!
[1/1] firmware: qcom_scm: Add SM6375 compatible
commit: fb1eb0b5dcf6f214479e853ee466958190785ab4
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-22 14:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-07 1:22 [PATCH] firmware: qcom_scm: Add SM6375 compatible Konrad Dybcio
2023-03-07 13:13 ` Konrad Dybcio
2023-03-22 3:36 ` Bjorn Andersson
2023-03-22 14:45 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox