[PATCH -next v2] spi: rockchip-sfc: Use devm_platform_ioremap_resource()

[PATCH -next v2] spi: rockchip-sfc: Use devm_platform_ioremap_resource()

[Yang Li]

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_ioremap_resource(), as this is exactly what this
function does.

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---

change in v2:
--According to Tudor's suggestion, use devm_platform_ioremap_resource() and
  get rid of the local variable too.

 drivers/spi/spi-rockchip-sfc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c
index 4fabd2e0439f..b370aade11b4 100644
--- a/drivers/spi/spi-rockchip-sfc.c
+++ b/drivers/spi/spi-rockchip-sfc.c
@@ -558,7 +558,6 @@ static int rockchip_sfc_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct spi_master *master;
-	struct resource *res;
 	struct rockchip_sfc *sfc;
 	int ret;
 
@@ -576,8 +575,7 @@ static int rockchip_sfc_probe(struct platform_device *pdev)
 	sfc = spi_master_get_devdata(master);
 	sfc->dev = dev;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	sfc->regbase = devm_ioremap_resource(dev, res);
+	sfc->regbase = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(sfc->regbase))
 		return PTR_ERR(sfc->regbase);
 
-- 
2.20.1.7.g153144c

Re: [PATCH -next v2] spi: rockchip-sfc: Use devm_platform_ioremap_resource()

[Tudor Ambarus]

On 3/29/23 07:24, Yang Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_ioremap_resource(), as this is exactly what this
> function does.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

I still prefer a single patch per subsystem, but Mark is going to decide:

Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> 
> change in v2:
> --According to Tudor's suggestion, use devm_platform_ioremap_resource() and
>   get rid of the local variable too.
> 
>  drivers/spi/spi-rockchip-sfc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c
> index 4fabd2e0439f..b370aade11b4 100644
> --- a/drivers/spi/spi-rockchip-sfc.c
> +++ b/drivers/spi/spi-rockchip-sfc.c
> @@ -558,7 +558,6 @@ static int rockchip_sfc_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	struct spi_master *master;
> -	struct resource *res;
>  	struct rockchip_sfc *sfc;
>  	int ret;
>  
> @@ -576,8 +575,7 @@ static int rockchip_sfc_probe(struct platform_device *pdev)
>  	sfc = spi_master_get_devdata(master);
>  	sfc->dev = dev;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	sfc->regbase = devm_ioremap_resource(dev, res);
> +	sfc->regbase = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(sfc->regbase))
>  		return PTR_ERR(sfc->regbase);
>  

Re: [PATCH -next v2] spi: rockchip-sfc: Use devm_platform_ioremap_resource()

[Mark Brown]

On Wed, 29 Mar 2023 14:24:50 +0800, Yang Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_ioremap_resource(), as this is exactly what this
> function does.
> 
> 

Applied to

   broonie/spi.git for-6.4

Thanks!

[1/1] spi: rockchip-sfc: Use devm_platform_ioremap_resource()
      commit: 526c2966fca3337f01c513b1f0d85c839f8d8175

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark