From: Zhang Rui <rui.zhang@intel.com>
To: jdelvare@suse.com, linux@roeck-us.net
Cc: linux-hwmon@vger.kernel.org, peter.ganzhorn@gmail.com,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/2] hwmon: (coretemp) Delete tjmax debug message
Date: Thu, 30 Mar 2023 18:33:45 +0800 [thread overview]
Message-ID: <20230330103346.6044-1-rui.zhang@intel.com> (raw)
After commit c0c67f8761ce ("hwmon: (coretemp) Add support for dynamic
tjmax"), tjmax value is retrieved from MSR every time the temperature is
read.
This means that, with debug message enabled, the tjmax debug message is
printed out for every single temperature read for any CPU. This spams
the syslog.
Ideally, as tjmax is package scope unique, the debug message should show
once when tjmax is changed for one package. But this requires inventing
some new per-package data in the coretemp driver, and this is overkill.
To keep the code simple, delete the tjmax debug message.
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
drivers/hwmon/coretemp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index 30d77f451937..fe3d4d0dcbed 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -286,10 +286,8 @@ static int get_tjmax(struct temp_data *tdata, struct device *dev)
* If the TjMax is not plausible, an assumption
* will be used
*/
- if (val) {
- dev_dbg(dev, "TjMax is %d degrees C\n", val);
+ if (val)
return val * 1000;
- }
}
if (force_tjmax) {
--
2.25.1
next reply other threads:[~2023-03-30 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 10:33 Zhang Rui [this message]
2023-03-30 10:33 ` [PATCH v2 2/2] hwmon: (coretemp) Delete an obsolete comment Zhang Rui
2023-04-07 16:01 ` Guenter Roeck
2023-04-07 16:00 ` [PATCH v2 1/2] hwmon: (coretemp) Delete tjmax debug message Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330103346.6044-1-rui.zhang@intel.com \
--to=rui.zhang@intel.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peter.ganzhorn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox