From: Zhang Rui <rui.zhang@intel.com>
To: jdelvare@suse.com, linux@roeck-us.net
Cc: linux-hwmon@vger.kernel.org, peter.ganzhorn@gmail.com,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/2] hwmon: (coretemp) Delete an obsolete comment
Date: Thu, 30 Mar 2023 18:33:46 +0800 [thread overview]
Message-ID: <20230330103346.6044-2-rui.zhang@intel.com> (raw)
In-Reply-To: <20230330103346.6044-1-rui.zhang@intel.com>
The refinement of tjmax value retrieved from MSR_IA32_TEMPERATURE_TARGET
has been changed for several times.
Now, the raw value from MSR is used without refinement. Thus remove the
obsolete comment.
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
drivers/hwmon/coretemp.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index fe3d4d0dcbed..eba94f68585a 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -282,10 +282,6 @@ static int get_tjmax(struct temp_data *tdata, struct device *dev)
dev_warn(dev, "Unable to read TjMax from CPU %u\n", tdata->cpu);
} else {
val = (eax >> 16) & 0xff;
- /*
- * If the TjMax is not plausible, an assumption
- * will be used
- */
if (val)
return val * 1000;
}
--
2.25.1
next prev parent reply other threads:[~2023-03-30 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 10:33 [PATCH v2 1/2] hwmon: (coretemp) Delete tjmax debug message Zhang Rui
2023-03-30 10:33 ` Zhang Rui [this message]
2023-04-07 16:01 ` [PATCH v2 2/2] hwmon: (coretemp) Delete an obsolete comment Guenter Roeck
2023-04-07 16:00 ` [PATCH v2 1/2] hwmon: (coretemp) Delete tjmax debug message Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330103346.6044-2-rui.zhang@intel.com \
--to=rui.zhang@intel.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peter.ganzhorn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox