From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Keguang Zhang <keguang.zhang@gmail.com>
Cc: linux-watchdog@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Yang Ling <gnaygnil@gmail.com>
Subject: Re: [PATCH 1/2] MIPS: Loongson32: Remove reset.c
Date: Thu, 30 Mar 2023 13:30:53 +0200 [thread overview]
Message-ID: <20230330113053.GB9674@alpha.franken.de> (raw)
In-Reply-To: <20230330102013.545588-2-keguang.zhang@gmail.com>
On Thu, Mar 30, 2023 at 06:20:12PM +0800, Keguang Zhang wrote:
> The Loongson-1 restart handler will be moved to watchdog driver,
> then _machine_restart is no longer needed.
> The _machine_halt and pm_power_off are also unnecessary,
> which contain no hardware operations.
>
> Therefore, remove the entire reset.c and related header file.
> Update the Makefile accordingly.
>
> Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
> ---
> .../include/asm/mach-loongson32/regs-wdt.h | 15 ------
> arch/mips/loongson32/common/Makefile | 2 +-
> arch/mips/loongson32/common/reset.c | 51 -------------------
> 3 files changed, 1 insertion(+), 67 deletions(-)
> delete mode 100644 arch/mips/include/asm/mach-loongson32/regs-wdt.h
> delete mode 100644 arch/mips/loongson32/common/reset.c
Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2023-03-30 11:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 10:20 [PATCH 0/2] Move Loongson1 restart handler to watchdog driver Keguang Zhang
2023-03-30 10:20 ` [PATCH 1/2] MIPS: Loongson32: Remove reset.c Keguang Zhang
2023-03-30 11:30 ` Thomas Bogendoerfer [this message]
2023-04-17 3:28 ` Keguang Zhang
2023-03-30 10:20 ` [PATCH 2/2] watchdog: loongson1_wdt: Implement restart handler Keguang Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330113053.GB9674@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=gnaygnil@gmail.com \
--cc=keguang.zhang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox