* [PATCH v7 1/2] dt-bindings: soc: starfive: Add StarFive syscon doc
2023-04-06 10:33 [PATCH v7 0/2] StarFive's SYSCON support William Qiu
@ 2023-04-06 10:33 ` William Qiu
2023-04-06 18:30 ` Krzysztof Kozlowski
2023-04-06 10:33 ` [PATCH v7 2/2] riscv: dts: starfive: jh7110: Add syscon nodes William Qiu
2023-04-29 18:58 ` [PATCH v7 0/2] StarFive's SYSCON support Palmer Dabbelt
2 siblings, 1 reply; 8+ messages in thread
From: William Qiu @ 2023-04-06 10:33 UTC (permalink / raw)
To: devicetree, linux-riscv, linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Emil Renner Berthing, William Qiu
Add documentation to describe StarFive System Controller Registers.
Signed-off-by: William Qiu <william.qiu@starfivetech.com>
---
.../soc/starfive/starfive,jh7110-syscon.yaml | 56 +++++++++++++++++++
MAINTAINERS | 5 ++
2 files changed, 61 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
diff --git a/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml b/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
new file mode 100644
index 000000000000..0d0319426b67
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/starfive/starfive,jh7110-syscon.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: StarFive JH7110 SoC system controller
+
+maintainers:
+ - William Qiu <william.qiu@starfivetech.com>
+
+description: |
+ The StarFive JH7110 SoC system controller provides register information such
+ as offset, mask and shift to configure related modules such as MMC and PCIe.
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - starfive,jh7110-aon-syscon
+ - starfive,jh7110-sys-syscon
+ - const: syscon
+ - const: simple-mfd
+ - items:
+ - const: starfive,jh7110-stg-syscon
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+ clock-controller:
+ type: object
+
+ power-controller:
+ type: object
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ syscon@10240000 {
+ compatible = "starfive,jh7110-stg-syscon", "syscon";
+ reg = <0x10240000 0x1000>;
+ };
+
+ syscon@13030000 {
+ compatible = "starfive,jh7110-sys-syscon", "syscon", "simple-mfd";
+ reg = <0x13030000 0x1000>;
+ };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 4c0b39c44957..0b2170e1e4ff 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19911,6 +19911,11 @@ S: Supported
F: Documentation/devicetree/bindings/mmc/starfive*
F: drivers/mmc/host/dw_mmc-starfive.c
+STARFIVE JH7110 SYSCON
+M: William Qiu <william.qiu@starfivetech.com>
+S: Supported
+F: Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
+
STARFIVE JH71X0 CLOCK DRIVERS
M: Emil Renner Berthing <kernel@esmil.dk>
M: Hal Feng <hal.feng@starfivetech.com>
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v7 1/2] dt-bindings: soc: starfive: Add StarFive syscon doc
2023-04-06 10:33 ` [PATCH v7 1/2] dt-bindings: soc: starfive: Add StarFive syscon doc William Qiu
@ 2023-04-06 18:30 ` Krzysztof Kozlowski
2023-04-07 9:30 ` William Qiu
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2023-04-06 18:30 UTC (permalink / raw)
To: William Qiu, devicetree, linux-riscv, linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Emil Renner Berthing
On 06/04/2023 12:33, William Qiu wrote:
> Add documentation to describe StarFive System Controller Registers.
Subject: drop second/last, redundant "doc". The "dt-bindings" prefix is
already stating that these are documentation files.
>
> Signed-off-by: William Qiu <william.qiu@starfivetech.com>
> ---
> .../soc/starfive/starfive,jh7110-syscon.yaml | 56 +++++++++++++++++++
> MAINTAINERS | 5 ++
> 2 files changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml b/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
> new file mode 100644
> index 000000000000..0d0319426b67
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/starfive/starfive,jh7110-syscon.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: StarFive JH7110 SoC system controller
> +
> +maintainers:
> + - William Qiu <william.qiu@starfivetech.com>
> +
> +description: |
> + The StarFive JH7110 SoC system controller provides register information such
> + as offset, mask and shift to configure related modules such as MMC and PCIe.
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - starfive,jh7110-aon-syscon
> + - starfive,jh7110-sys-syscon
> + - const: syscon
> + - const: simple-mfd
> + - items:
> + - const: starfive,jh7110-stg-syscon
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> + clock-controller:
> + type: object
This should be rather specific schema, so $ref.
> +
> + power-controller:
> + type: object
Same problem.
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + syscon@10240000 {
> + compatible = "starfive,jh7110-stg-syscon", "syscon";
> + reg = <0x10240000 0x1000>;
> + };
> +
> + syscon@13030000 {
> + compatible = "starfive,jh7110-sys-syscon", "syscon", "simple-mfd";
> + reg = <0x13030000 0x1000>;
> + };
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v7 1/2] dt-bindings: soc: starfive: Add StarFive syscon doc
2023-04-06 18:30 ` Krzysztof Kozlowski
@ 2023-04-07 9:30 ` William Qiu
2023-04-07 10:11 ` Conor Dooley
0 siblings, 1 reply; 8+ messages in thread
From: William Qiu @ 2023-04-07 9:30 UTC (permalink / raw)
To: Krzysztof Kozlowski, devicetree, linux-riscv, linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Emil Renner Berthing
On 2023/4/7 2:30, Krzysztof Kozlowski wrote:
> On 06/04/2023 12:33, William Qiu wrote:
>> Add documentation to describe StarFive System Controller Registers.
>
> Subject: drop second/last, redundant "doc". The "dt-bindings" prefix is
> already stating that these are documentation files.
>
Will fix.
>>
>> Signed-off-by: William Qiu <william.qiu@starfivetech.com>
>> ---
>> .../soc/starfive/starfive,jh7110-syscon.yaml | 56 +++++++++++++++++++
>> MAINTAINERS | 5 ++
>> 2 files changed, 61 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml b/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
>> new file mode 100644
>> index 000000000000..0d0319426b67
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
>> @@ -0,0 +1,56 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/soc/starfive/starfive,jh7110-syscon.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: StarFive JH7110 SoC system controller
>> +
>> +maintainers:
>> + - William Qiu <william.qiu@starfivetech.com>
>> +
>> +description: |
>> + The StarFive JH7110 SoC system controller provides register information such
>> + as offset, mask and shift to configure related modules such as MMC and PCIe.
>> +
>> +properties:
>> + compatible:
>> + oneOf:
>> + - items:
>> + - enum:
>> + - starfive,jh7110-aon-syscon
>> + - starfive,jh7110-sys-syscon
>> + - const: syscon
>> + - const: simple-mfd
>> + - items:
>> + - const: starfive,jh7110-stg-syscon
>> + - const: syscon
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + clock-controller:
>> + type: object
>
> This should be rather specific schema, so $ref.
>
This would be $ref: /schemas/clock/starfive,jh7110-pll.yaml#, but this file is not
available at present, so I would like to ask if I should submit the documents
instead of Xingyu
>> +
>> + power-controller:
>> + type: object
>
Will fix, it would be $ref: /schemas/power/starfive,jh7110-pmu.yaml#.
Best regards,
William
> Same problem.
>
>> +
>> +required:
>> + - compatible
>> + - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + syscon@10240000 {
>> + compatible = "starfive,jh7110-stg-syscon", "syscon";
>> + reg = <0x10240000 0x1000>;
>> + };
>> +
>> + syscon@13030000 {
>> + compatible = "starfive,jh7110-sys-syscon", "syscon", "simple-mfd";
>> + reg = <0x13030000 0x1000>;
>> + };
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v7 1/2] dt-bindings: soc: starfive: Add StarFive syscon doc
2023-04-07 9:30 ` William Qiu
@ 2023-04-07 10:11 ` Conor Dooley
2023-04-07 11:17 ` William Qiu
0 siblings, 1 reply; 8+ messages in thread
From: Conor Dooley @ 2023-04-07 10:11 UTC (permalink / raw)
To: William Qiu
Cc: Krzysztof Kozlowski, devicetree, linux-riscv, linux-kernel,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Emil Renner Berthing
[-- Attachment #1: Type: text/plain, Size: 1497 bytes --]
On Fri, Apr 07, 2023 at 05:30:31PM +0800, William Qiu wrote:
>
> This would be $ref: /schemas/clock/starfive,jh7110-pll.yaml#, but this file is not
> available at present, so I would like to ask if I should submit the documents
> instead of Xingyu
Or just send the whole lot as one series, and I'll ack the soc bits for
Stephen to take the whole lot via clk? I think Xingyu owes a respin
anyway cos of the changes to this binding file that Krzysztof requested
there.
Plus, the base clock support is now in clk-next, so their stuff is now
applicable to the clk tree.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4c0b39c44957..0b2170e1e4ff 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19911,6 +19911,11 @@ S: Supported
> F: Documentation/devicetree/bindings/mmc/starfive*
> F: drivers/mmc/host/dw_mmc-starfive.c
>
> +STARFIVE JH7110 SYSCON
> +M: William Qiu <william.qiu@starfivetech.com>
> +S: Supported
> +F: Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
Can you squash this in please (whitespace damaged):
diff --git a/MAINTAINERS b/MAINTAINERS
index 90abe83c02f3..6fbb486f59ab 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19943,6 +19943,7 @@ STARFIVE SOC DRIVERS
M: Conor Dooley <conor@kernel.org>
S: Maintained
T: git https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/
+F: Documentation/devicetree/bindings/soc/starfive/
F: drivers/soc/starfive/
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v7 1/2] dt-bindings: soc: starfive: Add StarFive syscon doc
2023-04-07 10:11 ` Conor Dooley
@ 2023-04-07 11:17 ` William Qiu
0 siblings, 0 replies; 8+ messages in thread
From: William Qiu @ 2023-04-07 11:17 UTC (permalink / raw)
To: Conor Dooley
Cc: Krzysztof Kozlowski, devicetree, linux-riscv, linux-kernel,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Emil Renner Berthing
On 2023/4/7 18:11, Conor Dooley wrote:
> On Fri, Apr 07, 2023 at 05:30:31PM +0800, William Qiu wrote:
>>
>> This would be $ref: /schemas/clock/starfive,jh7110-pll.yaml#, but this file is not
>> available at present, so I would like to ask if I should submit the documents
>> instead of Xingyu
>
> Or just send the whole lot as one series, and I'll ack the soc bits for
> Stephen to take the whole lot via clk? I think Xingyu owes a respin
> anyway cos of the changes to this binding file that Krzysztof requested
> there.
>
> Plus, the base clock support is now in clk-next, so their stuff is now
> applicable to the clk tree.
>
So it is the best choice to give the whole series to Xingyu?
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 4c0b39c44957..0b2170e1e4ff 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -19911,6 +19911,11 @@ S: Supported
>> F: Documentation/devicetree/bindings/mmc/starfive*
>> F: drivers/mmc/host/dw_mmc-starfive.c
>>
>> +STARFIVE JH7110 SYSCON
>> +M: William Qiu <william.qiu@starfivetech.com>
>> +S: Supported
>> +F: Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
>
> Can you squash this in please (whitespace damaged):
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 90abe83c02f3..6fbb486f59ab 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19943,6 +19943,7 @@ STARFIVE SOC DRIVERS
> M: Conor Dooley <conor@kernel.org>
> S: Maintained
> T: git https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/
> +F: Documentation/devicetree/bindings/soc/starfive/
> F: drivers/soc/starfive/
>
I would tell Xingyu to do so.
Best regards,
William
> Cheers,
> Conor.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v7 2/2] riscv: dts: starfive: jh7110: Add syscon nodes
2023-04-06 10:33 [PATCH v7 0/2] StarFive's SYSCON support William Qiu
2023-04-06 10:33 ` [PATCH v7 1/2] dt-bindings: soc: starfive: Add StarFive syscon doc William Qiu
@ 2023-04-06 10:33 ` William Qiu
2023-04-29 18:58 ` [PATCH v7 0/2] StarFive's SYSCON support Palmer Dabbelt
2 siblings, 0 replies; 8+ messages in thread
From: William Qiu @ 2023-04-06 10:33 UTC (permalink / raw)
To: devicetree, linux-riscv, linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Emil Renner Berthing, William Qiu
Add stg_syscon/sys_syscon/aon_syscon nodes for JH7110 Soc.
Signed-off-by: William Qiu <william.qiu@starfivetech.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
---
arch/riscv/boot/dts/starfive/jh7110.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
index 4c5fdb905da8..f271c3184d3a 100644
--- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
+++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
@@ -353,6 +353,11 @@ i2c2: i2c@10050000 {
status = "disabled";
};
+ stg_syscon: syscon@10240000 {
+ compatible = "starfive,jh7110-stg-syscon", "syscon";
+ reg = <0x0 0x10240000 0x0 0x1000>;
+ };
+
uart3: serial@12000000 {
compatible = "snps,dw-apb-uart";
reg = <0x0 0x12000000 0x0 0x10000>;
@@ -457,6 +462,11 @@ syscrg: clock-controller@13020000 {
#reset-cells = <1>;
};
+ sys_syscon: syscon@13030000 {
+ compatible = "starfive,jh7110-sys-syscon", "syscon", "simple-mfd";
+ reg = <0x0 0x13030000 0x0 0x1000>;
+ };
+
sysgpio: pinctrl@13040000 {
compatible = "starfive,jh7110-sys-pinctrl";
reg = <0x0 0x13040000 0x0 0x10000>;
@@ -486,6 +496,11 @@ aoncrg: clock-controller@17000000 {
#reset-cells = <1>;
};
+ aon_syscon: syscon@17010000 {
+ compatible = "starfive,jh7110-aon-syscon", "syscon", "simple-mfd";
+ reg = <0x0 0x17010000 0x0 0x1000>;
+ };
+
aongpio: pinctrl@17020000 {
compatible = "starfive,jh7110-aon-pinctrl";
reg = <0x0 0x17020000 0x0 0x10000>;
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v7 0/2] StarFive's SYSCON support
2023-04-06 10:33 [PATCH v7 0/2] StarFive's SYSCON support William Qiu
2023-04-06 10:33 ` [PATCH v7 1/2] dt-bindings: soc: starfive: Add StarFive syscon doc William Qiu
2023-04-06 10:33 ` [PATCH v7 2/2] riscv: dts: starfive: jh7110: Add syscon nodes William Qiu
@ 2023-04-29 18:58 ` Palmer Dabbelt
2 siblings, 0 replies; 8+ messages in thread
From: Palmer Dabbelt @ 2023-04-29 18:58 UTC (permalink / raw)
To: william.qiu
Cc: devicetree, linux-riscv, linux-kernel, robh+dt,
krzysztof.kozlowski+dt, Conor Dooley, kernel, william.qiu
On Thu, 06 Apr 2023 03:33:06 PDT (-0700), william.qiu@starfivetech.com wrote:
> Hi,
>
> This patchset adds initial rudimentary support for the StarFive
> designware mobile storage host controller driver. And this driver will
> be used in StarFive's VisionFive 2 board. The main purpose of adding
> this driver is to accommodate the ultra-high speed mode of eMMC.
>
> The last patch should be applied after the patchset [1]:
> [1] https://lore.kernel.org/all/20230401111934.130844-1-hal.feng@starfivetech.com/
>
> Changes v5->v6:
> - Rebased to 6.3-rc3.
> - Modified compatible's property.
> - Added clock-controller and power-controller node.
>
> Changes v5->v6:
> - Rebased to 6.3-rc1.
> - Changed file name to starfive,jh7110.yaml.
> - Modified commit description.
> - Added syscon node dts patch to other dependent modules.
>
> Changes v4->v5:
> - Added a incremental updates to fix a bug that prev_err is uninitialized.
> - Dropped the merged patches.
> - Dropped the dts patch.
> - Sorted compatible alphabetically in yaml.
>
> Changes v3->v4:
> - Added documentation to describe StarFive System Controller Registers.
> - Added aon_syscon and stg_syscon node.
> - Fixed some checkpatch errors/warnings.
>
> Changes v2->v3:
> - Wraped commit message according to Linux coding style.
> - Rephrased the description of the patches.
> - Changed the description of syscon regsiter.
> - Dropped redundant properties.
>
> Changes v1->v2:
> - Renamed the dt-binding 'starfive,jh7110-sdio.yaml' to 'starfive,jh7110-mmc.yaml'.
> - Changed the type of 'starfive,syscon' and modify its description.
> - Deleted unused head files like '#include <linux/gpio.h>'.
> - Added comment for the 'rise_point' and 'fall_point'.
> - Changed the API 'num_caps' to 'common_caps'.
> - Changed the node name 'sys_syscon' to 'syscon'.
> - Changed the node name 'sdio' to 'mmc'.
>
> The patch series is based on v6.3.
>
> William Qiu (2):
> dt-bindings: soc: starfive: Add StarFive syscon doc
> riscv: dts: starfive: jh7110: Add syscon nodes
>
> .../soc/starfive/starfive,jh7110-syscon.yaml | 56 +++++++++++++++++++
> MAINTAINERS | 5 ++
> arch/riscv/boot/dts/starfive/jh7110.dtsi | 15 +++++
> 3 files changed, 76 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml
Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
^ permalink raw reply [flat|nested] 8+ messages in thread