From: Peter Zijlstra <peterz@infradead.org>
To: Aaron Lu <aaron.lu@intel.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, Olivier Dion <odion@efficios.com>,
michael.christie@oracle.com
Subject: Re: [RFC PATCH v4] sched: Fix performance regression introduced by mm_cid
Date: Wed, 12 Apr 2023 11:10:43 +0200 [thread overview]
Message-ID: <20230412091043.GC4253@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20230411131221.GA7356@ziqianlu-desk2>
On Tue, Apr 11, 2023 at 09:12:21PM +0800, Aaron Lu wrote:
> Forget about this "v4 is better than v2 and v3" part, my later test
> showed the contention can also rise to around 18% for v4.
So while I can reproduce the initial regression on a HSW-EX system
(4*18*2) and get lovely things like:
34.47%--schedule_hrtimeout_range_clock
schedule
|
--34.42%--__schedule
|
|--31.86%--_raw_spin_lock
| |
| --31.65%--native_queued_spin_lock_slowpath
|
--0.72%--dequeue_task_fair
|
--0.60%--dequeue_entity
On a --threads=144 run; it is completely gone when I use v4:
6.92%--__schedule
|
|--2.16%--dequeue_task_fair
| |
| --1.69%--dequeue_entity
| |
| |--0.61%--update_load_avg
| |
| --0.54%--update_curr
|
|--1.30%--pick_next_task_fair
| |
| --0.54%--set_next_entity
|
|--0.77%--psi_task_switch
|
--0.69%--switch_mm_irqs_off
:-(
next prev parent reply other threads:[~2023-04-12 9:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 15:01 [RFC PATCH v4] sched: Fix performance regression introduced by mm_cid Mathieu Desnoyers
2023-04-10 21:51 ` michael.christie
2023-04-11 4:52 ` Aaron Lu
2023-04-11 13:12 ` Aaron Lu
2023-04-12 9:10 ` Peter Zijlstra [this message]
2023-04-12 11:42 ` Aaron Lu
2023-04-12 14:26 ` Peter Zijlstra
2023-04-12 14:39 ` Aaron Lu
2023-04-13 11:10 ` Peter Zijlstra
2023-04-13 13:49 ` Aaron Lu
2023-04-13 13:56 ` Mathieu Desnoyers
2023-04-13 15:20 ` Peter Zijlstra
2023-04-13 15:37 ` Mathieu Desnoyers
2023-04-12 4:27 ` Aaron Lu
2023-04-12 20:57 ` Mathieu Desnoyers
2023-04-13 13:13 ` Aaron Lu
2023-04-13 13:38 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412091043.GC4253@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aaron.lu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=michael.christie@oracle.com \
--cc=odion@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox