From: Tony Luck <tony.luck@intel.com>
To: Fenghua Yu <fenghua.yu@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Shaopeng Tan <tan.shaopeng@fujitsu.com>,
Jamie Iles <quic_jiles@quicinc.com>,
James Morse <james.morse@arm.com>,
Babu Moger <babu.moger@amd.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Tony Luck <tony.luck@intel.com>
Subject: [RFC PATCH 1/7] x86/resctrl: Add register/unregister functions for driver to hook into resctrl
Date: Thu, 20 Apr 2023 15:06:30 -0700 [thread overview]
Message-ID: <20230420220636.53527-2-tony.luck@intel.com> (raw)
In-Reply-To: <20230420220636.53527-1-tony.luck@intel.com>
Just one callback at the point for the driver to be notified when the
resctrl filesystem is mounted or unmounted. Virtually all drivers
will need this hook to enable/disable their feature(s) as part of
mount/unmount.
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
include/linux/resctrl.h | 13 +++++++
arch/x86/kernel/cpu/resctrl/rdtgroup.c | 50 ++++++++++++++++++++++++++
2 files changed, 63 insertions(+)
diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
index 8334eeacfec5..78513edddca0 100644
--- a/include/linux/resctrl.h
+++ b/include/linux/resctrl.h
@@ -204,6 +204,19 @@ struct resctrl_schema {
u32 num_closid;
};
+/**
+ * struct resctrl_driver - interface for driver to attach to resctrl
+ * @list: List of registered drivers
+ * @mount: Callback for mount/unmount
+ */
+struct resctrl_driver {
+ struct list_head list;
+ void (*mount)(bool mount);
+};
+
+int resctrl_register_driver(struct resctrl_driver *d);
+void resctrl_unregister_driver(struct resctrl_driver *d);
+
/* The number of closid supported by this resource regardless of CDP */
u32 resctrl_arch_get_num_closid(struct rdt_resource *r);
int resctrl_arch_update_domains(struct rdt_resource *r, u32 closid);
diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
index 6ad33f355861..3e6778bde427 100644
--- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
+++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
@@ -51,6 +51,9 @@ static struct kernfs_node *kn_mongrp;
/* Kernel fs node for "mon_data" directory under root */
static struct kernfs_node *kn_mondata;
+static LIST_HEAD(drivers);
+static bool resctrl_is_mounted;
+
static struct seq_buf last_cmd_status;
static char last_cmd_status_buf[512];
@@ -2437,6 +2440,42 @@ static int schemata_list_create(void)
return ret;
}
+static void driver_up(struct resctrl_driver *d)
+{
+ if (d->mount)
+ d->mount(true);
+}
+
+static void driver_down(struct resctrl_driver *d)
+{
+ if (d->mount)
+ d->mount(false);
+}
+
+int resctrl_register_driver(struct resctrl_driver *d)
+{
+ mutex_lock(&rdtgroup_mutex);
+ list_add(&d->list, &drivers);
+
+ if (resctrl_is_mounted)
+ driver_up(d);
+ mutex_unlock(&rdtgroup_mutex);
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(resctrl_register_driver);
+
+void resctrl_unregister_driver(struct resctrl_driver *d)
+{
+ mutex_lock(&rdtgroup_mutex);
+ list_del(&d->list);
+
+ if (resctrl_is_mounted)
+ driver_down(d);
+ mutex_unlock(&rdtgroup_mutex);
+}
+EXPORT_SYMBOL_GPL(resctrl_unregister_driver);
+
static void schemata_list_destroy(void)
{
struct resctrl_schema *s, *tmp;
@@ -2450,6 +2489,7 @@ static void schemata_list_destroy(void)
static int rdt_get_tree(struct fs_context *fc)
{
struct rdt_fs_context *ctx = rdt_fc2context(fc);
+ struct resctrl_driver *d;
struct rdt_domain *dom;
struct rdt_resource *r;
int ret;
@@ -2516,6 +2556,10 @@ static int rdt_get_tree(struct fs_context *fc)
mbm_setup_overflow_handler(dom, MBM_OVERFLOW_INTERVAL);
}
+ list_for_each_entry(d, &drivers, list)
+ driver_up(d);
+ resctrl_is_mounted = true;
+
goto out;
out_psl:
@@ -2761,6 +2805,7 @@ static void rmdir_all_sub(void)
static void rdt_kill_sb(struct super_block *sb)
{
+ struct resctrl_driver *d;
struct rdt_resource *r;
cpus_read_lock();
@@ -2780,6 +2825,11 @@ static void rdt_kill_sb(struct super_block *sb)
static_branch_disable_cpuslocked(&rdt_mon_enable_key);
static_branch_disable_cpuslocked(&rdt_enable_key);
kernfs_kill_sb(sb);
+
+ list_for_each_entry(d, &drivers, list)
+ driver_down(d);
+ resctrl_is_mounted = false;
+
mutex_unlock(&rdtgroup_mutex);
cpus_read_unlock();
}
--
2.39.2
next prev parent reply other threads:[~2023-04-20 22:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 22:06 [RFC PATCH 0/7] Add driver registration i/f to resctrl Tony Luck
2023-04-20 22:06 ` Tony Luck [this message]
2023-05-05 23:17 ` [RFC PATCH 1/7] x86/resctrl: Add register/unregister functions for driver to hook into resctrl Reinette Chatre
2023-04-20 22:06 ` [RFC PATCH 2/7] x86/resctrl: Add an interface to add/remove a new info/directory Tony Luck
2023-04-20 22:06 ` [RFC PATCH 3/7] x86/resctrl: Add driver callback when directories are removed Tony Luck
2023-05-05 23:19 ` Reinette Chatre
2023-04-20 22:06 ` [RFC PATCH 4/7] x86/resctrl: Add capability to driver registration to create control files Tony Luck
2023-05-05 23:20 ` Reinette Chatre
2023-04-20 22:06 ` [RFC PATCH 5/7] x86/resctrl: Enhance driver registration to hook into schemata files Tony Luck
2023-05-05 23:20 ` Reinette Chatre
2023-04-20 22:06 ` [RFC PATCH 6/7] x86/resctrl: Allow a device to override an existing schemata entry Tony Luck
2023-05-05 23:20 ` Reinette Chatre
2023-04-20 22:06 ` [RFC PATCH 7/7] x86/resctrl: Example resctrl driver Tony Luck
2023-05-05 23:17 ` [RFC PATCH 0/7] Add driver registration i/f to resctrl Reinette Chatre
2023-05-08 18:32 ` Luck, Tony
2023-05-09 21:34 ` Reinette Chatre
2023-05-09 23:35 ` Luck, Tony
2023-05-10 0:07 ` Reinette Chatre
2023-05-10 0:52 ` Luck, Tony
2023-05-11 20:35 ` Luck, Tony
2023-05-12 16:57 ` Reinette Chatre
2023-05-12 20:35 ` Luck, Tony
2023-05-12 21:08 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420220636.53527-2-tony.luck@intel.com \
--to=tony.luck@intel.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=quic_jiles@quicinc.com \
--cc=reinette.chatre@intel.com \
--cc=tan.shaopeng@fujitsu.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox