From: Tony Luck <tony.luck@intel.com>
To: Fenghua Yu <fenghua.yu@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Shaopeng Tan <tan.shaopeng@fujitsu.com>,
Jamie Iles <quic_jiles@quicinc.com>,
James Morse <james.morse@arm.com>,
Babu Moger <babu.moger@amd.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Tony Luck <tony.luck@intel.com>
Subject: [RFC PATCH 6/7] x86/resctrl: Allow a device to override an existing schemata entry
Date: Thu, 20 Apr 2023 15:06:35 -0700 [thread overview]
Message-ID: <20230420220636.53527-7-tony.luck@intel.com> (raw)
In-Reply-To: <20230420220636.53527-1-tony.luck@intel.com>
Remove that entry from the resctrl_schema_all list when driver
is loaded. Put it back again when driver is unloaded.
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
include/linux/resctrl.h | 4 ++++
arch/x86/kernel/cpu/resctrl/rdtgroup.c | 19 +++++++++++++++++++
2 files changed, 23 insertions(+)
diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
index 691805214f41..246644f53bde 100644
--- a/include/linux/resctrl.h
+++ b/include/linux/resctrl.h
@@ -223,6 +223,8 @@ struct resctrl_fileinfo {
* @rmdir: Callback when a resctrl directory is removed.
* @ctrlfiles: Array of files to create in ctrlmon directories.
* @schema: Driver supplied to manage a line in schemata file.
+ * @schema_override: Name of resource in schemata to override.
+ * @save_schema: List to save overridden schema while driver loaded
*/
struct resctrl_driver {
struct list_head list;
@@ -232,6 +234,8 @@ struct resctrl_driver {
int (*rmdir)(int oclos, int ormid, int nclos, int nrmid);
struct resctrl_fileinfo *ctrlfiles;
struct resctrl_schema schema;
+ char *schema_override;
+ struct list_head save_schema;
};
int resctrl_register_driver(struct resctrl_driver *d);
diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
index cc2292a7435b..4fc12ad56843 100644
--- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
+++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
@@ -2547,6 +2547,19 @@ static void rdtgroup_update_ctrl_dir(struct resctrl_fileinfo *files, bool add)
}
}
+static void driver_override(struct resctrl_driver *d)
+{
+ struct resctrl_schema *rs;
+
+ list_for_each_entry(rs, &resctrl_schema_all, list) {
+ if (strncmp(d->schema_override, rs->name, sizeof(rs->name)))
+ continue;
+ INIT_LIST_HEAD(&d->save_schema);
+ list_move(&rs->list, &d->save_schema);
+ break;
+ }
+}
+
static void driver_up(struct resctrl_driver *d)
{
if (d->mount)
@@ -2575,6 +2588,9 @@ int resctrl_register_driver(struct resctrl_driver *d)
if (d->schema.name[0])
list_add(&d->schema.list, &resctrl_schema_all);
+ if (d->schema_override)
+ driver_override(d);
+
if (resctrl_is_mounted)
driver_up(d);
mutex_unlock(&rdtgroup_mutex);
@@ -2592,6 +2608,9 @@ void resctrl_unregister_driver(struct resctrl_driver *d)
if (d->schema.name[0])
list_del(&d->schema.list);
+ if (d->schema_override && !list_empty(&d->save_schema))
+ list_move(d->save_schema.next, &resctrl_schema_all);
+
if (resctrl_is_mounted)
driver_down(d);
mutex_unlock(&rdtgroup_mutex);
--
2.39.2
next prev parent reply other threads:[~2023-04-20 22:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 22:06 [RFC PATCH 0/7] Add driver registration i/f to resctrl Tony Luck
2023-04-20 22:06 ` [RFC PATCH 1/7] x86/resctrl: Add register/unregister functions for driver to hook into resctrl Tony Luck
2023-05-05 23:17 ` Reinette Chatre
2023-04-20 22:06 ` [RFC PATCH 2/7] x86/resctrl: Add an interface to add/remove a new info/directory Tony Luck
2023-04-20 22:06 ` [RFC PATCH 3/7] x86/resctrl: Add driver callback when directories are removed Tony Luck
2023-05-05 23:19 ` Reinette Chatre
2023-04-20 22:06 ` [RFC PATCH 4/7] x86/resctrl: Add capability to driver registration to create control files Tony Luck
2023-05-05 23:20 ` Reinette Chatre
2023-04-20 22:06 ` [RFC PATCH 5/7] x86/resctrl: Enhance driver registration to hook into schemata files Tony Luck
2023-05-05 23:20 ` Reinette Chatre
2023-04-20 22:06 ` Tony Luck [this message]
2023-05-05 23:20 ` [RFC PATCH 6/7] x86/resctrl: Allow a device to override an existing schemata entry Reinette Chatre
2023-04-20 22:06 ` [RFC PATCH 7/7] x86/resctrl: Example resctrl driver Tony Luck
2023-05-05 23:17 ` [RFC PATCH 0/7] Add driver registration i/f to resctrl Reinette Chatre
2023-05-08 18:32 ` Luck, Tony
2023-05-09 21:34 ` Reinette Chatre
2023-05-09 23:35 ` Luck, Tony
2023-05-10 0:07 ` Reinette Chatre
2023-05-10 0:52 ` Luck, Tony
2023-05-11 20:35 ` Luck, Tony
2023-05-12 16:57 ` Reinette Chatre
2023-05-12 20:35 ` Luck, Tony
2023-05-12 21:08 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420220636.53527-7-tony.luck@intel.com \
--to=tony.luck@intel.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=quic_jiles@quicinc.com \
--cc=reinette.chatre@intel.com \
--cc=tan.shaopeng@fujitsu.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox