From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Roger Quadros <rogerq@kernel.org>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"r-gunasekaran@ti.com" <r-gunasekaran@ti.com>,
"srk@ti.com" <srk@ti.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc3: gadget: Fix controller timeout at dwc3_gadget_suspend()
Date: Fri, 28 Apr 2023 18:40:59 +0000 [thread overview]
Message-ID: <20230428184055.cm3lae6dmmfxgjc6@synopsys.com> (raw)
In-Reply-To: <20230428120812.107123-1-rogerq@kernel.org>
On Fri, Apr 28, 2023, Roger Quadros wrote:
> If gadget driver is loaded and we are connected to a USB host,
> all transfers must be stopped before stopping the controller else
> we will not get a clean stop i.e. dwc3_gadget_run_stop() will take
> several seconds to complete and will return -ETIMEDOUT. Fix this.
>
> No need to stop the controller at dwc3_gadget_suspend() if
> dwc->softconnect is 0 as controller is already stopped.
>
> Handle error cases properly in dwc3_gadget_suspend().
We also fix the dwc3_gadget_resume() in this change. Either create a
separate change or note it in the $subject and commit message.
>
> Suggested-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
Perhaps this needs a fixes tag? (Even though it can't be backported
cleanly without some modifications)
Also, please rebase your change to Greg's usb-next.
Thanks!
Thinh
prev parent reply other threads:[~2023-04-28 18:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 12:08 [PATCH] usb: dwc3: gadget: Fix controller timeout at dwc3_gadget_suspend() Roger Quadros
2023-04-28 18:40 ` Thinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230428184055.cm3lae6dmmfxgjc6@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=r-gunasekaran@ti.com \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox