[PATCH] ubi: Refuse attaching if mtd's erasesize is 0

[PATCH] ubi: Refuse attaching if mtd's erasesize is 0

[Zhihao Cheng]

There exists mtd devices with zero erasesize, which will trigger a
divide-by-zero exception while attaching ubi device.
Fix it by refusing attaching if mtd's erasesize is 0.

Fixes: 801c135ce73d ("UBI: Unsorted Block Images")
Reported-by: Yu Hao <yhao016@ucr.edu>
Link: https://lore.kernel.org/lkml/977347543.226888.1682011999468.JavaMail.zimbra@nod.at/T/
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
---
 drivers/mtd/ubi/build.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
index 6a2d1ef8d43c..69e92c31ace0 100644
--- a/drivers/mtd/ubi/build.c
+++ b/drivers/mtd/ubi/build.c
@@ -896,6 +896,13 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num,
 		return -EINVAL;
 	}
 
+	/* UBI cannot work on flashes with zero erasesize. */
+	if (!mtd->erasesize) {
+		pr_err("ubi: refuse attaching mtd%d - zero erasesize flash is not supported\n",
+			mtd->index);
+		return -EINVAL;
+	}
+
 	if (ubi_num == UBI_DEV_NUM_AUTO) {
 		/* Search for an empty slot in the @ubi_devices array */
 		for (ubi_num = 0; ubi_num < UBI_MAX_DEVICES; ubi_num++)
-- 
2.31.1

Re: [PATCH] ubi: Refuse attaching if mtd's erasesize is 0

[Miquel Raynal]

Hello,

chengzhihao1@huawei.com wrote on Sun, 23 Apr 2023 19:10:41 +0800:

> There exists mtd devices with zero erasesize, which will trigger a
> divide-by-zero exception while attaching ubi device.
> Fix it by refusing attaching if mtd's erasesize is 0.
> 
> Fixes: 801c135ce73d ("UBI: Unsorted Block Images")

IMHO, this should be backported to keep the vulnerable area as
small as possible, so:

Cc: stable@vger.kernel.org

> Reported-by: Yu Hao <yhao016@ucr.edu>
> Link: https://lore.kernel.org/lkml/977347543.226888.1682011999468.JavaMail.zimbra@nod.at/T/
> Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

> ---
>  drivers/mtd/ubi/build.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
> index 6a2d1ef8d43c..69e92c31ace0 100644
> --- a/drivers/mtd/ubi/build.c
> +++ b/drivers/mtd/ubi/build.c
> @@ -896,6 +896,13 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num,
>  		return -EINVAL;
>  	}
>  
> +	/* UBI cannot work on flashes with zero erasesize. */
> +	if (!mtd->erasesize) {
> +		pr_err("ubi: refuse attaching mtd%d - zero erasesize flash is not supported\n",
> +			mtd->index);
> +		return -EINVAL;
> +	}
> +
>  	if (ubi_num == UBI_DEV_NUM_AUTO) {
>  		/* Search for an empty slot in the @ubi_devices array */
>  		for (ubi_num = 0; ubi_num < UBI_MAX_DEVICES; ubi_num++)


Thanks,
Miquèl