* [PATCH] Staging: rts5208 :rtsx : fixed a brace coding style issue
@ 2023-05-14 3:09 Deepanshu Kartikey
2023-05-14 4:40 ` Greg KH
2023-05-15 6:41 ` Dan Carpenter
0 siblings, 2 replies; 3+ messages in thread
From: Deepanshu Kartikey @ 2023-05-14 3:09 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Deepanshu Kartikey
Fixed a coding style issue
Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
---
drivers/staging/rts5208/rtsx.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 2284a96abcff..0ab9355873f7 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
chip->srb->device->id,
(u8)chip->srb->device->lun);
chip->srb->result = DID_BAD_TARGET << 16;
- }
-
- /* we've got a command, let's do it! */
- else {
+ } else {
+ //we've got a command, let's do it!
scsi_show_command(chip);
rtsx_invoke_transport(chip->srb, chip);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Staging: rts5208 :rtsx : fixed a brace coding style issue
2023-05-14 3:09 [PATCH] Staging: rts5208 :rtsx : fixed a brace coding style issue Deepanshu Kartikey
@ 2023-05-14 4:40 ` Greg KH
2023-05-15 6:41 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2023-05-14 4:40 UTC (permalink / raw)
To: Deepanshu Kartikey; +Cc: linux-staging, linux-kernel
On Sun, May 14, 2023 at 08:39:40AM +0530, Deepanshu Kartikey wrote:
> Fixed a coding style issue
And you added another one when doing so :(
Please be specific about what you are fixing, and look at your use of
spaces in the subject and in the changelog text to verify it all makes
sense.
Please fix up and submit a new version of this change.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: rts5208 :rtsx : fixed a brace coding style issue
2023-05-14 3:09 [PATCH] Staging: rts5208 :rtsx : fixed a brace coding style issue Deepanshu Kartikey
2023-05-14 4:40 ` Greg KH
@ 2023-05-15 6:41 ` Dan Carpenter
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2023-05-15 6:41 UTC (permalink / raw)
To: Deepanshu Kartikey; +Cc: gregkh, linux-staging, linux-kernel
On Sun, May 14, 2023 at 08:39:40AM +0530, Deepanshu Kartikey wrote:
> Fixed a coding style issue
>
> Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
> ---
> drivers/staging/rts5208/rtsx.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index 2284a96abcff..0ab9355873f7 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
> chip->srb->device->id,
> (u8)chip->srb->device->lun);
> chip->srb->result = DID_BAD_TARGET << 16;
> - }
> -
> - /* we've got a command, let's do it! */
> - else {
> + } else {
> + //we've got a command, let's do it!
Don't change the comment style for no reason. Try to be consistent with
the rest of the file.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-15 6:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-14 3:09 [PATCH] Staging: rts5208 :rtsx : fixed a brace coding style issue Deepanshu Kartikey
2023-05-14 4:40 ` Greg KH
2023-05-15 6:41 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).