* [PATCH v2] gpio: sa1100: include <mach/generic.h>
@ 2023-05-17 9:52 Arnd Bergmann
2023-05-17 9:56 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2023-05-17 9:52 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: Arnd Bergmann, linux-gpio, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
sa1100_init_gpio() is declared in a machine specific header so it
can be called from platform code, but the definition is in the device
driver, which causes a warning:
drivers/gpio/gpio-sa1100.c:310:13: error: no previous prototype for 'sa1100_init_gpio' [-Werror=missing-prototypes]
It's already possible to include mach/generic.h from drivers, so add
this one here as well.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
v2: rebase back on mainline tree
---
drivers/gpio/gpio-sa1100.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-sa1100.c b/drivers/gpio/gpio-sa1100.c
index edff5e81489f..242dad763ac4 100644
--- a/drivers/gpio/gpio-sa1100.c
+++ b/drivers/gpio/gpio-sa1100.c
@@ -12,6 +12,7 @@
#include <soc/sa1100/pwer.h>
#include <mach/hardware.h>
#include <mach/irqs.h>
+#include <mach/generic.h>
struct sa1100_gpio_chip {
struct gpio_chip chip;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] gpio: sa1100: include <mach/generic.h>
2023-05-17 9:52 [PATCH v2] gpio: sa1100: include <mach/generic.h> Arnd Bergmann
@ 2023-05-17 9:56 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2023-05-17 9:56 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Linus Walleij, Arnd Bergmann, linux-gpio, linux-kernel
On Wed, May 17, 2023 at 11:53 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> sa1100_init_gpio() is declared in a machine specific header so it
> can be called from platform code, but the definition is in the device
> driver, which causes a warning:
>
> drivers/gpio/gpio-sa1100.c:310:13: error: no previous prototype for 'sa1100_init_gpio' [-Werror=missing-prototypes]
>
> It's already possible to include mach/generic.h from drivers, so add
> this one here as well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: rebase back on mainline tree
> ---
> drivers/gpio/gpio-sa1100.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-sa1100.c b/drivers/gpio/gpio-sa1100.c
> index edff5e81489f..242dad763ac4 100644
> --- a/drivers/gpio/gpio-sa1100.c
> +++ b/drivers/gpio/gpio-sa1100.c
> @@ -12,6 +12,7 @@
> #include <soc/sa1100/pwer.h>
> #include <mach/hardware.h>
> #include <mach/irqs.h>
> +#include <mach/generic.h>
>
> struct sa1100_gpio_chip {
> struct gpio_chip chip;
> --
> 2.39.2
>
Now applied, thanks!
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-17 9:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-17 9:52 [PATCH v2] gpio: sa1100: include <mach/generic.h> Arnd Bergmann
2023-05-17 9:56 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox