* [PATCH] clk: qcom: gcc-ipq6018: remove duplicate initializers
@ 2023-06-01 21:34 Arnd Bergmann
2023-06-01 21:57 ` Dmitry Baryshkov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-06-01 21:34 UTC (permalink / raw)
To: Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Robert Marko
Cc: Arnd Bergmann, Mantas Pucka, Christian Marangi, linux-arm-msm,
linux-clk, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
A recent change added new initializers for .config_ctl_val and
.config_ctl_hi_val but left the old values in place:
drivers/clk/qcom/gcc-ipq6018.c:4155:27: error: initialized field overwritten [-Werror=override-init]
4155 | .config_ctl_val = 0x240d4828,
| ^~~~~~~~~~
drivers/clk/qcom/gcc-ipq6018.c:4156:30: error: initialized field overwritten [-Werror=override-init]
4156 | .config_ctl_hi_val = 0x6,
| ^~~
Remove the unused ones now to avoid confusion.
Fixes: f4f0c8acee0e4 ("clk: qcom: gcc-ipq6018: update UBI32 PLL")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/qcom/gcc-ipq6018.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/clk/qcom/gcc-ipq6018.c b/drivers/clk/qcom/gcc-ipq6018.c
index 48f9bff7c80fb..86b43175b0422 100644
--- a/drivers/clk/qcom/gcc-ipq6018.c
+++ b/drivers/clk/qcom/gcc-ipq6018.c
@@ -4150,8 +4150,6 @@ static struct clk_branch gcc_dcc_clk = {
static const struct alpha_pll_config ubi32_pll_config = {
.l = 0x3e,
.alpha = 0x6667,
- .config_ctl_val = 0x240d6aa8,
- .config_ctl_hi_val = 0x3c2,
.config_ctl_val = 0x240d4828,
.config_ctl_hi_val = 0x6,
.main_output_mask = BIT(0),
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] clk: qcom: gcc-ipq6018: remove duplicate initializers
2023-06-01 21:34 [PATCH] clk: qcom: gcc-ipq6018: remove duplicate initializers Arnd Bergmann
@ 2023-06-01 21:57 ` Dmitry Baryshkov
2023-06-01 22:05 ` Robert Marko
2023-06-13 23:48 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2023-06-01 21:57 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Robert Marko, Arnd Bergmann, Mantas Pucka,
Christian Marangi, linux-arm-msm, linux-clk, linux-kernel
On Fri, 2 Jun 2023 at 00:34, Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> A recent change added new initializers for .config_ctl_val and
> .config_ctl_hi_val but left the old values in place:
>
> drivers/clk/qcom/gcc-ipq6018.c:4155:27: error: initialized field overwritten [-Werror=override-init]
> 4155 | .config_ctl_val = 0x240d4828,
> | ^~~~~~~~~~
> drivers/clk/qcom/gcc-ipq6018.c:4156:30: error: initialized field overwritten [-Werror=override-init]
> 4156 | .config_ctl_hi_val = 0x6,
> | ^~~
>
> Remove the unused ones now to avoid confusion.
>
> Fixes: f4f0c8acee0e4 ("clk: qcom: gcc-ipq6018: update UBI32 PLL")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/clk/qcom/gcc-ipq6018.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: qcom: gcc-ipq6018: remove duplicate initializers
2023-06-01 21:34 [PATCH] clk: qcom: gcc-ipq6018: remove duplicate initializers Arnd Bergmann
2023-06-01 21:57 ` Dmitry Baryshkov
@ 2023-06-01 22:05 ` Robert Marko
2023-06-13 23:48 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Robert Marko @ 2023-06-01 22:05 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Michael Turquette,
Stephen Boyd, Arnd Bergmann, Mantas Pucka, Christian Marangi,
linux-arm-msm, linux-clk, linux-kernel
On Thu, 1 Jun 2023 at 23:34, Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> A recent change added new initializers for .config_ctl_val and
> .config_ctl_hi_val but left the old values in place:
>
> drivers/clk/qcom/gcc-ipq6018.c:4155:27: error: initialized field overwritten [-Werror=override-init]
> 4155 | .config_ctl_val = 0x240d4828,
> | ^~~~~~~~~~
> drivers/clk/qcom/gcc-ipq6018.c:4156:30: error: initialized field overwritten [-Werror=override-init]
> 4156 | .config_ctl_hi_val = 0x6,
> | ^~~
>
> Remove the unused ones now to avoid confusion.
>
> Fixes: f4f0c8acee0e4 ("clk: qcom: gcc-ipq6018: update UBI32 PLL")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for fixing my mess up.
Reviewed-by: Robert Marko <robimarko@gmail.com>
Regards,
Robert
> ---
> drivers/clk/qcom/gcc-ipq6018.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-ipq6018.c b/drivers/clk/qcom/gcc-ipq6018.c
> index 48f9bff7c80fb..86b43175b0422 100644
> --- a/drivers/clk/qcom/gcc-ipq6018.c
> +++ b/drivers/clk/qcom/gcc-ipq6018.c
> @@ -4150,8 +4150,6 @@ static struct clk_branch gcc_dcc_clk = {
> static const struct alpha_pll_config ubi32_pll_config = {
> .l = 0x3e,
> .alpha = 0x6667,
> - .config_ctl_val = 0x240d6aa8,
> - .config_ctl_hi_val = 0x3c2,
> .config_ctl_val = 0x240d4828,
> .config_ctl_hi_val = 0x6,
> .main_output_mask = BIT(0),
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: qcom: gcc-ipq6018: remove duplicate initializers
2023-06-01 21:34 [PATCH] clk: qcom: gcc-ipq6018: remove duplicate initializers Arnd Bergmann
2023-06-01 21:57 ` Dmitry Baryshkov
2023-06-01 22:05 ` Robert Marko
@ 2023-06-13 23:48 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-06-13 23:48 UTC (permalink / raw)
To: Arnd Bergmann, Michael Turquette, Andy Gross, Stephen Boyd,
Konrad Dybcio, Robert Marko
Cc: Mantas Pucka, Arnd Bergmann, linux-kernel, Christian Marangi,
linux-arm-msm, linux-clk
On Thu, 1 Jun 2023 23:34:12 +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A recent change added new initializers for .config_ctl_val and
> .config_ctl_hi_val but left the old values in place:
>
> drivers/clk/qcom/gcc-ipq6018.c:4155:27: error: initialized field overwritten [-Werror=override-init]
> 4155 | .config_ctl_val = 0x240d4828,
> | ^~~~~~~~~~
> drivers/clk/qcom/gcc-ipq6018.c:4156:30: error: initialized field overwritten [-Werror=override-init]
> 4156 | .config_ctl_hi_val = 0x6,
> | ^~~
>
> [...]
Applied, thanks!
[1/1] clk: qcom: gcc-ipq6018: remove duplicate initializers
commit: 5ae7899765607e97e5eb34486336898c8d9ec654
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-13 23:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-01 21:34 [PATCH] clk: qcom: gcc-ipq6018: remove duplicate initializers Arnd Bergmann
2023-06-01 21:57 ` Dmitry Baryshkov
2023-06-01 22:05 ` Robert Marko
2023-06-13 23:48 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox