* [PATCH] drm/meson: venc: include linux/bitfield.h
@ 2023-06-02 12:45 Arnd Bergmann
2023-06-02 13:45 ` Neil Armstrong
2023-06-02 13:49 ` Neil Armstrong
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2023-06-02 12:45 UTC (permalink / raw)
To: Neil Armstrong, David Airlie, Daniel Vetter, Kevin Hilman,
Nicolas Belin
Cc: Arnd Bergmann, Jerome Brunet, Martin Blumenstingl, Tom Rix,
Carlo Caione, dri-devel, linux-amlogic, linux-arm-kernel,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Without this header, the use of FIELD_PREP() can cause a build failure:
drivers/gpu/drm/meson/meson_venc.c: In function 'meson_encl_set_gamma_table':
drivers/gpu/drm/meson/meson_venc.c:1595:24: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
Fixes: 51fc01a03442c ("drm/meson: venc: add ENCL encoder setup for MIPI-DSI output")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/meson/meson_venc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
index 2bdc2855e249b..3bf0d6e4fc30a 100644
--- a/drivers/gpu/drm/meson/meson_venc.c
+++ b/drivers/gpu/drm/meson/meson_venc.c
@@ -5,6 +5,7 @@
* Copyright (C) 2015 Amlogic, Inc. All rights reserved.
*/
+#include <linux/bitfield.h>
#include <linux/export.h>
#include <linux/iopoll.h>
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/meson: venc: include linux/bitfield.h
2023-06-02 12:45 [PATCH] drm/meson: venc: include linux/bitfield.h Arnd Bergmann
@ 2023-06-02 13:45 ` Neil Armstrong
2023-06-02 13:49 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2023-06-02 13:45 UTC (permalink / raw)
To: Arnd Bergmann, David Airlie, Daniel Vetter, Kevin Hilman,
Nicolas Belin
Cc: Arnd Bergmann, Jerome Brunet, Martin Blumenstingl, Tom Rix,
Carlo Caione, dri-devel, linux-amlogic, linux-arm-kernel,
linux-kernel
On 02/06/2023 14:45, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without this header, the use of FIELD_PREP() can cause a build failure:
>
> drivers/gpu/drm/meson/meson_venc.c: In function 'meson_encl_set_gamma_table':
> drivers/gpu/drm/meson/meson_venc.c:1595:24: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
>
> Fixes: 51fc01a03442c ("drm/meson: venc: add ENCL encoder setup for MIPI-DSI output")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/meson/meson_venc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> index 2bdc2855e249b..3bf0d6e4fc30a 100644
> --- a/drivers/gpu/drm/meson/meson_venc.c
> +++ b/drivers/gpu/drm/meson/meson_venc.c
> @@ -5,6 +5,7 @@
> * Copyright (C) 2015 Amlogic, Inc. All rights reserved.
> */
>
> +#include <linux/bitfield.h>
> #include <linux/export.h>
> #include <linux/iopoll.h>
>
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/meson: venc: include linux/bitfield.h
2023-06-02 12:45 [PATCH] drm/meson: venc: include linux/bitfield.h Arnd Bergmann
2023-06-02 13:45 ` Neil Armstrong
@ 2023-06-02 13:49 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2023-06-02 13:49 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, Kevin Hilman, Nicolas Belin,
Arnd Bergmann
Cc: Arnd Bergmann, Jerome Brunet, Martin Blumenstingl, Tom Rix,
Carlo Caione, dri-devel, linux-amlogic, linux-arm-kernel,
linux-kernel
Hi,
On Fri, 02 Jun 2023 14:45:24 +0200, Arnd Bergmann wrote:
> Without this header, the use of FIELD_PREP() can cause a build failure:
>
> drivers/gpu/drm/meson/meson_venc.c: In function 'meson_encl_set_gamma_table':
> drivers/gpu/drm/meson/meson_venc.c:1595:24: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
>
>
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
[1/1] drm/meson: venc: include linux/bitfield.h
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=664dba662cb313da9cbb1c944c472638a65c552e
--
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-02 13:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-02 12:45 [PATCH] drm/meson: venc: include linux/bitfield.h Arnd Bergmann
2023-06-02 13:45 ` Neil Armstrong
2023-06-02 13:49 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox