* [PATCH] gpio: delay: add OF_GPIO dependency
@ 2023-06-05 11:01 Arnd Bergmann
2023-06-05 14:31 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2023-06-05 11:01 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Alexander Stein
Cc: Arnd Bergmann, Andy Shevchenko, William Breathitt Gray, Pandith N,
Yinbo Zhu, Niklas Schnelle, Nuno Sá, Davide Ciminaghi,
linux-gpio, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The new driver fails to build when OF_GPIO is disabled:
drivers/gpio/gpio-delay.c: In function 'gpio_delay_of_xlate':
drivers/gpio/gpio-delay.c:79:39: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'
Fixes: cf5dec80c4e23 ("gpio: Add gpio delay driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpio/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index a1dac1345f60f..006abaedcae82 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -1735,6 +1735,7 @@ config GPIO_AGGREGATOR
config GPIO_DELAY
tristate "GPIO delay"
+ depends on OF_GPIO
help
Say yes here to enable the GPIO delay, which provides a way to
configure platform specific delays for GPIO ramp-up or ramp-down
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] gpio: delay: add OF_GPIO dependency
2023-06-05 11:01 [PATCH] gpio: delay: add OF_GPIO dependency Arnd Bergmann
@ 2023-06-05 14:31 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2023-06-05 14:31 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linus Walleij, Alexander Stein, Arnd Bergmann, Andy Shevchenko,
William Breathitt Gray, Pandith N, Yinbo Zhu, Niklas Schnelle,
Nuno Sá, Davide Ciminaghi, linux-gpio, linux-kernel
On Mon, Jun 5, 2023 at 1:02 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The new driver fails to build when OF_GPIO is disabled:
>
> drivers/gpio/gpio-delay.c: In function 'gpio_delay_of_xlate':
> drivers/gpio/gpio-delay.c:79:39: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'
>
> Fixes: cf5dec80c4e23 ("gpio: Add gpio delay driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpio/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index a1dac1345f60f..006abaedcae82 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1735,6 +1735,7 @@ config GPIO_AGGREGATOR
>
> config GPIO_DELAY
> tristate "GPIO delay"
> + depends on OF_GPIO
> help
> Say yes here to enable the GPIO delay, which provides a way to
> configure platform specific delays for GPIO ramp-up or ramp-down
> --
> 2.39.2
>
Thanks, Alexander beat you to it.
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-05 14:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-05 11:01 [PATCH] gpio: delay: add OF_GPIO dependency Arnd Bergmann
2023-06-05 14:31 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox