[PATCH 0/2] MIPS: Fix recent clutter with PATA_PLATFORM

[PATCH 0/2] MIPS: Fix recent clutter with PATA_PLATFORM

[Maciej W. Rozycki]

Hi,

 A recent change has cluttered irrelevant MIPS platforms such as MALTA 
with PATA_PLATFORM configuration question, which makes no sense for them.  
This small patch series addresses the original issue in the correct way.

 See individual change descriptions for details.  Please apply.

  Maciej

[PATCH 1/2] MIPS: Alchemy: Enable PATA_PLATFORM support

[Maciej W. Rozycki]

We have limited demand for platform PATA support across MIPS platforms:

$ find arch/mips -type f | sort | xargs grep -l pata_platform_info
arch/mips/alchemy/devboards/db1200.c
arch/mips/alchemy/devboards/db1300.c
arch/mips/sibyte/swarm/platform.c
$ 

certainly not high enough to justify enabling support for PATA_PLATFORM 
port-wide.  SiByte platforms are handled selectively already, so just 
make a similar arrangement for Alchemy DB1XXX platforms.

Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
---
 arch/mips/alchemy/Kconfig |    1 +
 1 file changed, 1 insertion(+)

linux-mips-alchemy-pata-platform.diff
Index: linux-macro/arch/mips/alchemy/Kconfig
===================================================================
--- linux-macro.orig/arch/mips/alchemy/Kconfig
+++ linux-macro/arch/mips/alchemy/Kconfig
@@ -14,6 +14,7 @@ config MIPS_DB1XXX
 	bool "Alchemy DB1XXX / PB1XXX boards"
 	select GPIOLIB
 	select HAVE_PCI
+	select HAVE_PATA_PLATFORM
 	select SYS_SUPPORTS_LITTLE_ENDIAN
 	select SYS_HAS_EARLY_PRINTK
 	help

Re: [PATCH 1/2] MIPS: Alchemy: Enable PATA_PLATFORM support

[Thomas Bogendoerfer]

On Thu, Jun 01, 2023 at 01:56:19PM +0100, Maciej W. Rozycki wrote:
> We have limited demand for platform PATA support across MIPS platforms:
> 
> $ find arch/mips -type f | sort | xargs grep -l pata_platform_info
> arch/mips/alchemy/devboards/db1200.c
> arch/mips/alchemy/devboards/db1300.c
> arch/mips/sibyte/swarm/platform.c
> $ 
> 
> certainly not high enough to justify enabling support for PATA_PLATFORM 
> port-wide.  SiByte platforms are handled selectively already, so just 
> make a similar arrangement for Alchemy DB1XXX platforms.
> 
> Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
> ---
>  arch/mips/alchemy/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> linux-mips-alchemy-pata-platform.diff
> Index: linux-macro/arch/mips/alchemy/Kconfig
> ===================================================================
> --- linux-macro.orig/arch/mips/alchemy/Kconfig
> +++ linux-macro/arch/mips/alchemy/Kconfig
> @@ -14,6 +14,7 @@ config MIPS_DB1XXX
>  	bool "Alchemy DB1XXX / PB1XXX boards"
>  	select GPIOLIB
>  	select HAVE_PCI
> +	select HAVE_PATA_PLATFORM
>  	select SYS_SUPPORTS_LITTLE_ENDIAN
>  	select SYS_HAS_EARLY_PRINTK
>  	help

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

[PATCH 2/2] Revert "MIPS: unhide PATA_PLATFORM"

[Maciej W. Rozycki]

Revert commit 75b18aac6fa3 ("MIPS: unhide PATA_PLATFORM") now that 
HAVE_PATA_PLATFORM is set selectively for all the relevant platforms.

Verified with `db1xxx_defconfig' and `sb1250_swarm_defconfig' by making 
sure PATA_PLATFORM is still there in `.config' with this change applied, 
and with `malta_defconfig' by making sure it's now gone.

Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
---
 arch/mips/Kconfig |    1 -
 1 file changed, 1 deletion(-)

linux-mips-no-pata-platform.diff
Index: linux-macro/arch/mips/Kconfig
===================================================================
--- linux-macro.orig/arch/mips/Kconfig
+++ linux-macro/arch/mips/Kconfig
@@ -79,7 +79,6 @@ config MIPS
 	select HAVE_LD_DEAD_CODE_DATA_ELIMINATION
 	select HAVE_MOD_ARCH_SPECIFIC
 	select HAVE_NMI
-	select HAVE_PATA_PLATFORM
 	select HAVE_PERF_EVENTS
 	select HAVE_PERF_REGS
 	select HAVE_PERF_USER_STACK_DUMP

Re: [PATCH 2/2] Revert "MIPS: unhide PATA_PLATFORM"

[Thomas Bogendoerfer]

On Thu, Jun 01, 2023 at 01:56:36PM +0100, Maciej W. Rozycki wrote:
> Revert commit 75b18aac6fa3 ("MIPS: unhide PATA_PLATFORM") now that 
> HAVE_PATA_PLATFORM is set selectively for all the relevant platforms.
> 
> Verified with `db1xxx_defconfig' and `sb1250_swarm_defconfig' by making 
> sure PATA_PLATFORM is still there in `.config' with this change applied, 
> and with `malta_defconfig' by making sure it's now gone.
> 
> Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
> ---
>  arch/mips/Kconfig |    1 -
>  1 file changed, 1 deletion(-)
> 
> linux-mips-no-pata-platform.diff
> Index: linux-macro/arch/mips/Kconfig
> ===================================================================
> --- linux-macro.orig/arch/mips/Kconfig
> +++ linux-macro/arch/mips/Kconfig
> @@ -79,7 +79,6 @@ config MIPS
>  	select HAVE_LD_DEAD_CODE_DATA_ELIMINATION
>  	select HAVE_MOD_ARCH_SPECIFIC
>  	select HAVE_NMI
> -	select HAVE_PATA_PLATFORM
>  	select HAVE_PERF_EVENTS
>  	select HAVE_PERF_REGS
>  	select HAVE_PERF_USER_STACK_DUMP

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]