From: Sam Ravnborg <sam@ravnborg.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Sui Jingfeng <suijingfeng@loongson.cn>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
Date: Sat, 17 Jun 2023 21:48:43 +0200 [thread overview]
Message-ID: <20230617194843.GA1854380@ravnborg.org> (raw)
In-Reply-To: <c70cb3cb326439a5868beb54d720538923f653d1.camel@crapouillou.net>
Hi Paul,
On Sat, Jun 17, 2023 at 09:13:37PM +0200, Paul Cercueil wrote:
> Hi,
>
> Le mercredi 07 juin 2023 à 19:06 +0800, Sui Jingfeng a écrit :
> > Otherwise its failed to pass basic compile test on platform without
> > REGMAP_MMIO selected by defconfig
> >
> > make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
> >
> > SYNC include/config/auto.conf.cmd
> > Checking missing-syscalls for N32
> > CALL scripts/checksyscalls.sh
> > Checking missing-syscalls for O32
> > CALL scripts/checksyscalls.sh
> > CALL scripts/checksyscalls.sh
> > MODPOST Module.symvers
> > ERROR: modpost: "__devm_regmap_init_mmio_clk"
> > [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
> > make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
> > make: *** [Makefile:1978: modpost] Error 2
> >
> > V2: Order alphabetically
> >
> > Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>
> The patch looks good to me. But I need an ACK from someone else to
> apply to drm-misc-next.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
next prev parent reply other threads:[~2023-06-17 19:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 11:06 [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO Sui Jingfeng
2023-06-13 7:31 ` [v2] " Sui Jingfeng
2023-06-17 19:13 ` [PATCH v2] " Paul Cercueil
2023-06-17 19:48 ` Sam Ravnborg [this message]
2023-06-17 20:41 ` Paul Cercueil
2023-06-18 6:22 ` Sui Jingfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230617194843.GA1854380@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=suijingfeng@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox