* [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
@ 2023-06-07 11:06 Sui Jingfeng
2023-06-13 7:31 ` [v2] " Sui Jingfeng
2023-06-17 19:13 ` [PATCH v2] " Paul Cercueil
0 siblings, 2 replies; 6+ messages in thread
From: Sui Jingfeng @ 2023-06-07 11:06 UTC (permalink / raw)
To: Paul Cercueil, David Airlie, Daniel Vetter
Cc: linux-mips, dri-devel, linux-kernel
Otherwise its failed to pass basic compile test on platform without
REGMAP_MMIO selected by defconfig
make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
SYNC include/config/auto.conf.cmd
Checking missing-syscalls for N32
CALL scripts/checksyscalls.sh
Checking missing-syscalls for O32
CALL scripts/checksyscalls.sh
CALL scripts/checksyscalls.sh
MODPOST Module.symvers
ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
make: *** [Makefile:1978: modpost] Error 2
V2: Order alphabetically
Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
---
drivers/gpu/drm/ingenic/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/ingenic/Kconfig b/drivers/gpu/drm/ingenic/Kconfig
index a53f475d33df..b440e0cdc057 100644
--- a/drivers/gpu/drm/ingenic/Kconfig
+++ b/drivers/gpu/drm/ingenic/Kconfig
@@ -9,6 +9,8 @@ config DRM_INGENIC
select DRM_PANEL_BRIDGE
select DRM_KMS_HELPER
select DRM_GEM_DMA_HELPER
+ select REGMAP
+ select REGMAP_MMIO
select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE
help
Choose this option for DRM support for the Ingenic SoCs.
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
2023-06-07 11:06 [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO Sui Jingfeng
@ 2023-06-13 7:31 ` Sui Jingfeng
2023-06-17 19:13 ` [PATCH v2] " Paul Cercueil
1 sibling, 0 replies; 6+ messages in thread
From: Sui Jingfeng @ 2023-06-13 7:31 UTC (permalink / raw)
To: Paul Cercueil, David Airlie, Daniel Vetter
Cc: linux-mips, dri-devel, linux-kernel
Hi,
Humble ping ?
On 2023/6/7 19:06, Sui Jingfeng wrote:
> Otherwise its failed to pass basic compile test on platform without
> REGMAP_MMIO selected by defconfig
>
> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
>
> SYNC include/config/auto.conf.cmd
> Checking missing-syscalls for N32
> CALL scripts/checksyscalls.sh
> Checking missing-syscalls for O32
> CALL scripts/checksyscalls.sh
> CALL scripts/checksyscalls.sh
> MODPOST Module.symvers
> ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
> make: *** [Makefile:1978: modpost] Error 2
>
> V2: Order alphabetically
>
> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> ---
> drivers/gpu/drm/ingenic/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/ingenic/Kconfig b/drivers/gpu/drm/ingenic/Kconfig
> index a53f475d33df..b440e0cdc057 100644
> --- a/drivers/gpu/drm/ingenic/Kconfig
> +++ b/drivers/gpu/drm/ingenic/Kconfig
> @@ -9,6 +9,8 @@ config DRM_INGENIC
> select DRM_PANEL_BRIDGE
> select DRM_KMS_HELPER
> select DRM_GEM_DMA_HELPER
> + select REGMAP
> + select REGMAP_MMIO
> select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE
> help
> Choose this option for DRM support for the Ingenic SoCs.
--
Jingfeng
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
2023-06-07 11:06 [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO Sui Jingfeng
2023-06-13 7:31 ` [v2] " Sui Jingfeng
@ 2023-06-17 19:13 ` Paul Cercueil
2023-06-17 19:48 ` Sam Ravnborg
1 sibling, 1 reply; 6+ messages in thread
From: Paul Cercueil @ 2023-06-17 19:13 UTC (permalink / raw)
To: Sui Jingfeng, David Airlie, Daniel Vetter
Cc: linux-mips, dri-devel, linux-kernel
Hi,
Le mercredi 07 juin 2023 à 19:06 +0800, Sui Jingfeng a écrit :
> Otherwise its failed to pass basic compile test on platform without
> REGMAP_MMIO selected by defconfig
>
> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
>
> SYNC include/config/auto.conf.cmd
> Checking missing-syscalls for N32
> CALL scripts/checksyscalls.sh
> Checking missing-syscalls for O32
> CALL scripts/checksyscalls.sh
> CALL scripts/checksyscalls.sh
> MODPOST Module.symvers
> ERROR: modpost: "__devm_regmap_init_mmio_clk"
> [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
> make: *** [Makefile:1978: modpost] Error 2
>
> V2: Order alphabetically
>
> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
The patch looks good to me. But I need an ACK from someone else to
apply to drm-misc-next.
Cheers,
-Paul
> ---
> drivers/gpu/drm/ingenic/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/ingenic/Kconfig
> b/drivers/gpu/drm/ingenic/Kconfig
> index a53f475d33df..b440e0cdc057 100644
> --- a/drivers/gpu/drm/ingenic/Kconfig
> +++ b/drivers/gpu/drm/ingenic/Kconfig
> @@ -9,6 +9,8 @@ config DRM_INGENIC
> select DRM_PANEL_BRIDGE
> select DRM_KMS_HELPER
> select DRM_GEM_DMA_HELPER
> + select REGMAP
> + select REGMAP_MMIO
> select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE
> help
> Choose this option for DRM support for the Ingenic SoCs.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
2023-06-17 19:13 ` [PATCH v2] " Paul Cercueil
@ 2023-06-17 19:48 ` Sam Ravnborg
2023-06-17 20:41 ` Paul Cercueil
0 siblings, 1 reply; 6+ messages in thread
From: Sam Ravnborg @ 2023-06-17 19:48 UTC (permalink / raw)
To: Paul Cercueil
Cc: Sui Jingfeng, David Airlie, Daniel Vetter, linux-mips, dri-devel,
linux-kernel
Hi Paul,
On Sat, Jun 17, 2023 at 09:13:37PM +0200, Paul Cercueil wrote:
> Hi,
>
> Le mercredi 07 juin 2023 à 19:06 +0800, Sui Jingfeng a écrit :
> > Otherwise its failed to pass basic compile test on platform without
> > REGMAP_MMIO selected by defconfig
> >
> > make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
> >
> > SYNC include/config/auto.conf.cmd
> > Checking missing-syscalls for N32
> > CALL scripts/checksyscalls.sh
> > Checking missing-syscalls for O32
> > CALL scripts/checksyscalls.sh
> > CALL scripts/checksyscalls.sh
> > MODPOST Module.symvers
> > ERROR: modpost: "__devm_regmap_init_mmio_clk"
> > [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
> > make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
> > make: *** [Makefile:1978: modpost] Error 2
> >
> > V2: Order alphabetically
> >
> > Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>
> The patch looks good to me. But I need an ACK from someone else to
> apply to drm-misc-next.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
2023-06-17 19:48 ` Sam Ravnborg
@ 2023-06-17 20:41 ` Paul Cercueil
2023-06-18 6:22 ` Sui Jingfeng
0 siblings, 1 reply; 6+ messages in thread
From: Paul Cercueil @ 2023-06-17 20:41 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Sui Jingfeng, David Airlie, Daniel Vetter, linux-mips, dri-devel,
linux-kernel
Hi,
Le samedi 17 juin 2023 à 21:48 +0200, Sam Ravnborg a écrit :
> Hi Paul,
> On Sat, Jun 17, 2023 at 09:13:37PM +0200, Paul Cercueil wrote:
> > Hi,
> >
> > Le mercredi 07 juin 2023 à 19:06 +0800, Sui Jingfeng a écrit :
> > > Otherwise its failed to pass basic compile test on platform
> > > without
> > > REGMAP_MMIO selected by defconfig
> > >
> > > make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
> > >
> > > SYNC include/config/auto.conf.cmd
> > > Checking missing-syscalls for N32
> > > CALL scripts/checksyscalls.sh
> > > Checking missing-syscalls for O32
> > > CALL scripts/checksyscalls.sh
> > > CALL scripts/checksyscalls.sh
> > > MODPOST Module.symvers
> > > ERROR: modpost: "__devm_regmap_init_mmio_clk"
> > > [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
> > > make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error
> > > 1
> > > make: *** [Makefile:1978: modpost] Error 2
> > >
> > > V2: Order alphabetically
> > >
> > > Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> >
> > The patch looks good to me. But I need an ACK from someone else to
> > apply to drm-misc-next.
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Thanks Sam!
Applied to drm-misc-next.
Cheers,
-Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
2023-06-17 20:41 ` Paul Cercueil
@ 2023-06-18 6:22 ` Sui Jingfeng
0 siblings, 0 replies; 6+ messages in thread
From: Sui Jingfeng @ 2023-06-18 6:22 UTC (permalink / raw)
To: Paul Cercueil, Sam Ravnborg
Cc: David Airlie, Daniel Vetter, linux-mips, dri-devel, linux-kernel
Hi,
On 2023/6/18 04:41, Paul Cercueil wrote:
> Hi,
>
> Le samedi 17 juin 2023 à 21:48 +0200, Sam Ravnborg a écrit :
>> Hi Paul,
>> On Sat, Jun 17, 2023 at 09:13:37PM +0200, Paul Cercueil wrote:
>>> Hi,
>>>
>>> Le mercredi 07 juin 2023 à 19:06 +0800, Sui Jingfeng a écrit :
>>>> Otherwise its failed to pass basic compile test on platform
>>>> without
>>>> REGMAP_MMIO selected by defconfig
>>>>
>>>> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
>>>>
>>>> SYNC include/config/auto.conf.cmd
>>>> Checking missing-syscalls for N32
>>>> CALL scripts/checksyscalls.sh
>>>> Checking missing-syscalls for O32
>>>> CALL scripts/checksyscalls.sh
>>>> CALL scripts/checksyscalls.sh
>>>> MODPOST Module.symvers
>>>> ERROR: modpost: "__devm_regmap_init_mmio_clk"
>>>> [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
>>>> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error
>>>> 1
>>>> make: *** [Makefile:1978: modpost] Error 2
>>>>
>>>> V2: Order alphabetically
>>>>
>>>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>>> The patch looks good to me. But I need an ACK from someone else to
>>> apply to drm-misc-next.
>> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> Thanks Sam!
Sam and Paul, thanks a lot, :-)
> Applied to drm-misc-next.
>
> Cheers,
> -Paul
--
Jingfeng
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-18 6:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-07 11:06 [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO Sui Jingfeng
2023-06-13 7:31 ` [v2] " Sui Jingfeng
2023-06-17 19:13 ` [PATCH v2] " Paul Cercueil
2023-06-17 19:48 ` Sam Ravnborg
2023-06-17 20:41 ` Paul Cercueil
2023-06-18 6:22 ` Sui Jingfeng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox