public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ryan McCann <quic_rmccann@quicinc.com>
To: Rob Clark <robdclark@gmail.com>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: Rob Clark <robdclark@chromium.org>,
	<linux-arm-msm@vger.kernel.org>,
	<dri-devel@lists.freedesktop.org>,
	<freedreno@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	<quic_jesszhan@quicinc.com>,
	Ryan McCann <quic_rmccann@quicinc.com>
Subject: [PATCH v4 1/6] drm/msm: Update dev core dump to not print backwards
Date: Thu, 6 Jul 2023 13:48:32 -0700	[thread overview]
Message-ID: <20230622-devcoredump_patch-v4-1-e304ddbe9648@quicinc.com> (raw)
In-Reply-To: <20230622-devcoredump_patch-v4-0-e304ddbe9648@quicinc.com>

Device core dump add block method adds hardware blocks to dumping queue
with stack behavior which causes the hardware blocks to be printed in
reverse order. Change the addition to dumping queue data structure
from "list_add" to "list_add_tail" for FIFO queue behavior.

Fixes: 98659487b845 ("drm/msm: add support to take dpu snapshot")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Signed-off-by: Ryan McCann <quic_rmccann@quicinc.com>
---
 drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c b/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c
index acfe1b31e079..add72bbc28b1 100644
--- a/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c
+++ b/drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c
@@ -192,5 +192,5 @@ void msm_disp_snapshot_add_block(struct msm_disp_state *disp_state, u32 len,
 	new_blk->base_addr = base_addr;
 
 	msm_disp_state_dump_regs(&new_blk->state, new_blk->size, base_addr);
-	list_add(&new_blk->node, &disp_state->blocks);
+	list_add_tail(&new_blk->node, &disp_state->blocks);
 }

-- 
2.25.1


  reply	other threads:[~2023-07-06 20:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06 20:48 [PATCH v4 0/6] Add support to print sub-block registers in dpu hw catalog Ryan McCann
2023-07-06 20:48 ` Ryan McCann [this message]
2023-07-06 20:48 ` [PATCH v4 2/6] drm/msm/dpu: Drop unused num argument from relevant macros Ryan McCann
2023-07-06 20:48 ` [PATCH v4 3/6] drm/msm/dpu: Define names for unnamed sblks Ryan McCann
2023-07-06 20:48 ` [PATCH v4 4/6] drm/msm/dpu: Remove redundant prefix/suffix in name of sub-blocks Ryan McCann
2023-07-06 20:48 ` [PATCH v4 5/6] drm/msm/dpu: Refactor printing of main blocks in device core dump Ryan McCann
2023-07-07  0:07   ` Dmitry Baryshkov
2023-07-07  0:16     ` Abhinav Kumar
2023-07-07  2:19       ` Dmitry Baryshkov
2023-07-07  2:24         ` Abhinav Kumar
2023-07-06 20:48 ` [PATCH v4 6/6] drm/msm/dpu: Update dev core dump to dump registers of sub-blocks Ryan McCann
2023-07-07  0:24   ` Dmitry Baryshkov
2023-07-07 20:49     ` Ryan McCann
2023-07-07 21:58       ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230622-devcoredump_patch-v4-1-e304ddbe9648@quicinc.com \
    --to=quic_rmccann@quicinc.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_jesszhan@quicinc.com \
    --cc=robdclark@chromium.org \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox