public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Min Li <min15.li@samsung.com>
Cc: hch@lst.de, axboe@kernel.dk, dlemoal@kernel.org,
	gregkh@linuxfoundation.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@kernel.org,
	willy@infradead.org
Subject: Re: [PATCH v3] block: add check that partition length needs to be aligned with block size
Date: Wed, 28 Jun 2023 10:38:39 +0200	[thread overview]
Message-ID: <20230628083839.GA26606@lst.de> (raw)
In-Reply-To: <20230628163442.2796-1-min15.li@samsung.com>

On Wed, Jun 28, 2023 at 04:34:42PM +0000, Min Li wrote:
> I will modify the blksz to unsigned int.
> For pre-existing start/length, is it ok to change them to sector_t?

They are long long in the UAPI, which is weird but has been that way
for a long time.  So I think we need checks for negative values
before they are shifted and converted to a sector_t.

  reply	other threads:[~2023-06-28  8:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230628051122epcas5p45d70f2c36ce91b60863f702de1534321@epcas5p4.samsung.com>
2023-06-28 13:09 ` [PATCH v3] block: add check that partition length needs to be aligned with block size Min Li
2023-06-28  6:05   ` Damien Le Moal
2023-06-28  7:32   ` Christoph Hellwig
2023-06-28 16:34     ` Min Li
2023-06-28  8:38       ` Christoph Hellwig [this message]
2023-06-28 17:07         ` Min Li
2023-06-29  1:04           ` Chaitanya Kulkarni
2023-06-29  1:04           ` Yu Kuai
2023-06-29  1:15             ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230628083839.GA26606@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=dlemoal@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=min15.li@samsung.com \
    --cc=stable@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox