From: Damien Le Moal <dlemoal@kernel.org>
To: Min Li <min15.li@samsung.com>,
axboe@kernel.dk, willy@infradead.org, hch@lst.de,
gregkh@linuxfoundation.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH v3] block: add check that partition length needs to be aligned with block size
Date: Wed, 28 Jun 2023 15:05:28 +0900 [thread overview]
Message-ID: <6232885e-d841-8067-b238-dda6f89f33f2@kernel.org> (raw)
In-Reply-To: <20230628130941.10690-1-min15.li@samsung.com>
On 6/28/23 22:09, Min Li wrote:
> Before calling add partition or resize partition, there is no check
> on whether the length is aligned with the logical block size.
> If the logical block size of the disk is larger than 512 bytes,
> then the partition size maybe not the multiple of the logical block size,
> and when the last sector is read, bio_truncate() will adjust the bio size,
> resulting in an IO error if the size of the read command is smaller than
> the logical block size.If integrity data is supported, this will also
> result in a null pointer dereference when calling bio_integrity_free.
>
> Signed-off-by: Min Li <min15.li@samsung.com>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2023-06-28 9:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230628051122epcas5p45d70f2c36ce91b60863f702de1534321@epcas5p4.samsung.com>
2023-06-28 13:09 ` [PATCH v3] block: add check that partition length needs to be aligned with block size Min Li
2023-06-28 6:05 ` Damien Le Moal [this message]
2023-06-28 7:32 ` Christoph Hellwig
2023-06-28 16:34 ` Min Li
2023-06-28 8:38 ` Christoph Hellwig
2023-06-28 17:07 ` Min Li
2023-06-29 1:04 ` Chaitanya Kulkarni
2023-06-29 1:04 ` Yu Kuai
2023-06-29 1:15 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6232885e-d841-8067-b238-dda6f89f33f2@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=min15.li@samsung.com \
--cc=stable@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox