* [PATCH] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults in schema
@ 2023-07-25 15:52 Eugen Hristev
2023-07-25 16:11 ` Sebastian Reichel
0 siblings, 1 reply; 3+ messages in thread
From: Eugen Hristev @ 2023-07-25 15:52 UTC (permalink / raw)
To: linux-kernel, linux-rockchip, linux-arm-kernel, devicetree,
netdev
Cc: david.wu, heiko, krzysztof.kozlowski+dt, kernel, Eugen Hristev
The defaults are specified in the description instead of being specified
in the schema.
Fix it by adding the default value in the `default` field.
Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-schema")
Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
---
Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
index bb943c96c196..6d08260ad828 100644
--- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
@@ -92,12 +92,14 @@ properties:
$ref: /schemas/types.yaml#/definitions/phandle
tx_delay:
- description: Delay value for TXD timing. Range value is 0~0x7F, 0x30 as default.
+ description: Delay value for TXD timing. Range value is 0~0x7F.
$ref: /schemas/types.yaml#/definitions/uint32
+ default: 0x30
rx_delay:
- description: Delay value for RXD timing. Range value is 0~0x7F, 0x10 as default.
+ description: Delay value for RXD timing. Range value is 0~0x7F.
$ref: /schemas/types.yaml#/definitions/uint32
+ default: 0x10
phy-supply:
description: PHY regulator
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults in schema
2023-07-25 15:52 [PATCH] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults in schema Eugen Hristev
@ 2023-07-25 16:11 ` Sebastian Reichel
2023-07-25 19:30 ` Conor Dooley
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Reichel @ 2023-07-25 16:11 UTC (permalink / raw)
To: Eugen Hristev
Cc: linux-kernel, linux-rockchip, linux-arm-kernel, devicetree,
netdev, david.wu, heiko, krzysztof.kozlowski+dt, kernel
[-- Attachment #1: Type: text/plain, Size: 1697 bytes --]
Hi,
On Tue, Jul 25, 2023 at 06:52:54PM +0300, Eugen Hristev wrote:
> The defaults are specified in the description instead of being specified
> in the schema.
> Fix it by adding the default value in the `default` field.
>
> Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-schema")
> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
> ---
Maybe also fix the allowed range while at it? I.e.
minimum: 0x00
maximum: 0x7F
-- Sebastian
> Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> index bb943c96c196..6d08260ad828 100644
> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> @@ -92,12 +92,14 @@ properties:
> $ref: /schemas/types.yaml#/definitions/phandle
>
> tx_delay:
> - description: Delay value for TXD timing. Range value is 0~0x7F, 0x30 as default.
> + description: Delay value for TXD timing. Range value is 0~0x7F.
> $ref: /schemas/types.yaml#/definitions/uint32
> + default: 0x30
>
> rx_delay:
> - description: Delay value for RXD timing. Range value is 0~0x7F, 0x10 as default.
> + description: Delay value for RXD timing. Range value is 0~0x7F.
> $ref: /schemas/types.yaml#/definitions/uint32
> + default: 0x10
>
> phy-supply:
> description: PHY regulator
> --
> 2.34.1
>
>
> --
> To unsubscribe, send mail to kernel-unsubscribe@lists.collabora.co.uk.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults in schema
2023-07-25 16:11 ` Sebastian Reichel
@ 2023-07-25 19:30 ` Conor Dooley
0 siblings, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2023-07-25 19:30 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Eugen Hristev, linux-kernel, linux-rockchip, linux-arm-kernel,
devicetree, netdev, david.wu, heiko, krzysztof.kozlowski+dt,
kernel
[-- Attachment #1: Type: text/plain, Size: 596 bytes --]
On Tue, Jul 25, 2023 at 06:11:56PM +0200, Sebastian Reichel wrote:
> Hi,
>
> On Tue, Jul 25, 2023 at 06:52:54PM +0300, Eugen Hristev wrote:
> > The defaults are specified in the description instead of being specified
> > in the schema.
> > Fix it by adding the default value in the `default` field.
> >
> > Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-schema")
> > Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
> > ---
>
> Maybe also fix the allowed range while at it? I.e.
>
> minimum: 0x00
> maximum: 0x7F
Beat me to it! Please do.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-25 19:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-25 15:52 [PATCH] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults in schema Eugen Hristev
2023-07-25 16:11 ` Sebastian Reichel
2023-07-25 19:30 ` Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox