public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Andy Shevchenko <andriy.shevchenko@intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Satish Nagireddy <satish.nagireddy@getcruise.com>,
	Matti Vaittinen <mazziesaccount@gmail.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v2 5/8] media: i2c: ds90ub960: Allow FPD-Link async mode
Date: Tue, 25 Jul 2023 19:38:18 +0300	[thread overview]
Message-ID: <20230725163818.GL31069@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20230720-fpdlink-additions-v2-5-b91b1eca2ad3@ideasonboard.com>

Hi Tomi,

Thank you for the patch.

On Thu, Jul 20, 2023 at 01:30:36PM +0300, Tomi Valkeinen wrote:
> Allow using FPD-Link in async mode. The driver handles it correctly, but
> the mode was blocked at probe time as there wasn't HW to test this with.
> Now the mode has been tested, and it works.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/i2c/ds90ub960.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
> index a83091f47140..ea819fb6e99b 100644
> --- a/drivers/media/i2c/ds90ub960.c
> +++ b/drivers/media/i2c/ds90ub960.c
> @@ -3240,7 +3240,6 @@ ub960_parse_dt_rxport_link_properties(struct ub960_data *priv,
>  	switch (rx_mode) {
>  	case RXPORT_MODE_RAW12_HF:
>  	case RXPORT_MODE_RAW12_LF:
> -	case RXPORT_MODE_CSI2_ASYNC:
>  		dev_err(dev, "rx%u: unsupported 'ti,rx-mode' %u\n", nport,
>  			rx_mode);
>  		return -EINVAL;
> 

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2023-07-25 16:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20 10:30 [PATCH v2 0/8] media: i2c: ds90ub9xx: Misc improvements Tomi Valkeinen
2023-07-20 10:30 ` [PATCH v2 1/8] media: i2c: ds90ub960: Configure CSI-2 continuous clock Tomi Valkeinen
2023-07-25 16:29   ` Laurent Pinchart
2023-07-20 10:30 ` [PATCH v2 2/8] media: i2c: ds90ub953: Use v4l2_fwnode_endpoint_parse() Tomi Valkeinen
2023-07-25 16:30   ` Laurent Pinchart
2023-07-20 10:30 ` [PATCH v2 3/8] media: i2c: ds90ub913: " Tomi Valkeinen
2023-07-25 16:34   ` Laurent Pinchart
2023-07-20 10:30 ` [PATCH v2 4/8] media: i2c: ds90ub953: Handle V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK Tomi Valkeinen
2023-07-25 16:36   ` Laurent Pinchart
2023-07-20 10:30 ` [PATCH v2 5/8] media: i2c: ds90ub960: Allow FPD-Link async mode Tomi Valkeinen
2023-07-25 16:38   ` Laurent Pinchart [this message]
2023-07-20 10:30 ` [PATCH v2 6/8] media: i2c: ds90ub953: Restructure clkout management Tomi Valkeinen
2023-07-21 10:29   ` Andy Shevchenko
2023-07-21 13:23     ` Tomi Valkeinen
2023-07-21 13:44       ` Andy Shevchenko
2023-07-25 16:50   ` Laurent Pinchart
2023-07-20 10:30 ` [PATCH v2 7/8] media: i2c: ds90ub953: Support non-sync mode Tomi Valkeinen
2023-07-25 16:44   ` Laurent Pinchart
2023-07-20 10:30 ` [PATCH v2 8/8] media: i2c: ds90ub960: Rename RXPORT_MODE_CSI2_ASYNC to RXPORT_MODE_CSI2_NONSYNC Tomi Valkeinen
2023-07-25 16:45   ` Laurent Pinchart
2023-07-21 10:32 ` [PATCH v2 0/8] media: i2c: ds90ub9xx: Misc improvements Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230725163818.GL31069@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=mazziesaccount@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=satish.nagireddy@getcruise.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox