From: Liu Song <liusong@linux.alibaba.com>
To: akpm@linux-foundation.org, dianders@chromium.org, pmladek@suse.com
Cc: liusong@linux.alibaba.com, linux-kernel@vger.kernel.org
Subject: [PATCH] watchdog/hardlockup: set watchdog_hardlockup_warned to true as early as possible
Date: Sun, 6 Aug 2023 00:01:44 +0800 [thread overview]
Message-ID: <20230805160144.121875-1-liusong@linux.alibaba.com> (raw)
Since we want to ensure only printing hardlockups once, it is necessary
to set "watchdog_hardlockup_warned" to true as early as possible.
Signed-off-by: Liu Song <liusong@linux.alibaba.com>
---
kernel/watchdog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 25d5627a6580..c4795f2d148c 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -180,6 +180,8 @@ void watchdog_hardlockup_check(unsigned int cpu, struct pt_regs *regs)
/* Only print hardlockups once. */
if (per_cpu(watchdog_hardlockup_warned, cpu))
return;
+ else
+ per_cpu(watchdog_hardlockup_warned, cpu) = true;
pr_emerg("Watchdog detected hard LOCKUP on cpu %d\n", cpu);
print_modules();
@@ -206,8 +208,6 @@ void watchdog_hardlockup_check(unsigned int cpu, struct pt_regs *regs)
if (hardlockup_panic)
nmi_panic(regs, "Hard LOCKUP");
-
- per_cpu(watchdog_hardlockup_warned, cpu) = true;
} else {
per_cpu(watchdog_hardlockup_warned, cpu) = false;
}
--
2.19.1.6.gb485710b
next reply other threads:[~2023-08-05 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-05 16:01 Liu Song [this message]
2023-08-05 17:17 ` [PATCH] watchdog/hardlockup: set watchdog_hardlockup_warned to true as early as possible Andrew Morton
2023-08-06 2:52 ` Liu Song
2023-08-07 13:54 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230805160144.121875-1-liusong@linux.alibaba.com \
--to=liusong@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox