* [PATCH] reset: ti: syscon: remove unneeded call to platform_set_drvdata()
@ 2023-08-07 11:15 Andrei Coardos
2023-08-07 11:57 ` Alexandru Ardelean
2023-08-08 13:46 ` Philipp Zabel
0 siblings, 2 replies; 4+ messages in thread
From: Andrei Coardos @ 2023-08-07 11:15 UTC (permalink / raw)
To: linux-kernel; +Cc: p.zabel, alex, Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
drivers/reset/reset-ti-syscon.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/reset/reset-ti-syscon.c b/drivers/reset/reset-ti-syscon.c
index f0dd7ffc3b72..23f86ddb8668 100644
--- a/drivers/reset/reset-ti-syscon.c
+++ b/drivers/reset/reset-ti-syscon.c
@@ -204,8 +204,6 @@ static int ti_syscon_reset_probe(struct platform_device *pdev)
data->controls = controls;
data->nr_controls = nr_controls;
- platform_set_drvdata(pdev, data);
-
return devm_reset_controller_register(dev, &data->rcdev);
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] reset: ti: syscon: remove unneeded call to platform_set_drvdata()
2023-08-07 11:15 [PATCH] reset: ti: syscon: remove unneeded call to platform_set_drvdata() Andrei Coardos
@ 2023-08-07 11:57 ` Alexandru Ardelean
2023-08-07 15:37 ` Andrew Davis
2023-08-08 13:46 ` Philipp Zabel
1 sibling, 1 reply; 4+ messages in thread
From: Alexandru Ardelean @ 2023-08-07 11:57 UTC (permalink / raw)
To: Andrei Coardos; +Cc: linux-kernel, p.zabel, afd, s-anna
On Mon, Aug 7, 2023 at 2:15 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
// also adding the people listed as MODULE_AUTHOR
// the list seems a bit short otherwise; no idea if these emails work
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
> drivers/reset/reset-ti-syscon.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/reset/reset-ti-syscon.c b/drivers/reset/reset-ti-syscon.c
> index f0dd7ffc3b72..23f86ddb8668 100644
> --- a/drivers/reset/reset-ti-syscon.c
> +++ b/drivers/reset/reset-ti-syscon.c
> @@ -204,8 +204,6 @@ static int ti_syscon_reset_probe(struct platform_device *pdev)
> data->controls = controls;
> data->nr_controls = nr_controls;
>
> - platform_set_drvdata(pdev, data);
> -
> return devm_reset_controller_register(dev, &data->rcdev);
> }
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] reset: ti: syscon: remove unneeded call to platform_set_drvdata()
2023-08-07 11:57 ` Alexandru Ardelean
@ 2023-08-07 15:37 ` Andrew Davis
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Davis @ 2023-08-07 15:37 UTC (permalink / raw)
To: Alexandru Ardelean, Andrei Coardos; +Cc: linux-kernel, p.zabel, s-anna
On 8/7/23 6:57 AM, Alexandru Ardelean wrote:
> On Mon, Aug 7, 2023 at 2:15 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>>
>> This function call was found to be unnecessary as there is no equivalent
>> platform_get_drvdata() call to access the private data of the driver. Also,
>> the private data is defined in this driver, so there is no risk of it being
>> accessed outside of this driver file.
>>
>
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
>
> // also adding the people listed as MODULE_AUTHOR
> // the list seems a bit short otherwise; no idea if these emails work
>
>> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
>> ---
LGTM,
Acked-by: Andrew Davis <afd@ti.com>
>> drivers/reset/reset-ti-syscon.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/reset/reset-ti-syscon.c b/drivers/reset/reset-ti-syscon.c
>> index f0dd7ffc3b72..23f86ddb8668 100644
>> --- a/drivers/reset/reset-ti-syscon.c
>> +++ b/drivers/reset/reset-ti-syscon.c
>> @@ -204,8 +204,6 @@ static int ti_syscon_reset_probe(struct platform_device *pdev)
>> data->controls = controls;
>> data->nr_controls = nr_controls;
>>
>> - platform_set_drvdata(pdev, data);
>> -
>> return devm_reset_controller_register(dev, &data->rcdev);
>> }
>>
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] reset: ti: syscon: remove unneeded call to platform_set_drvdata()
2023-08-07 11:15 [PATCH] reset: ti: syscon: remove unneeded call to platform_set_drvdata() Andrei Coardos
2023-08-07 11:57 ` Alexandru Ardelean
@ 2023-08-08 13:46 ` Philipp Zabel
1 sibling, 0 replies; 4+ messages in thread
From: Philipp Zabel @ 2023-08-08 13:46 UTC (permalink / raw)
To: Andrei Coardos, linux-kernel; +Cc: alex
On Mo, 2023-08-07 at 14:15 +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
Thank you, applied to reset/next.
regards
Philipp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-08 19:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-07 11:15 [PATCH] reset: ti: syscon: remove unneeded call to platform_set_drvdata() Andrei Coardos
2023-08-07 11:57 ` Alexandru Ardelean
2023-08-07 15:37 ` Andrew Davis
2023-08-08 13:46 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox