* [PATCH] thermal: k3_bandgap: remove unneeded call to platform_set_drvdata()
@ 2023-08-10 11:23 Andrei Coardos
2023-08-11 5:59 ` Alexandru Ardelean
2023-08-16 10:19 ` Daniel Lezcano
0 siblings, 2 replies; 3+ messages in thread
From: Andrei Coardos @ 2023-08-10 11:23 UTC (permalink / raw)
To: linux-kernel, linux-pm
Cc: rui.zhang, amitk, daniel.lezcano, rafael, alex, Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
---
drivers/thermal/k3_bandgap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/thermal/k3_bandgap.c b/drivers/thermal/k3_bandgap.c
index 1c3e590157ec..f985f36f2123 100644
--- a/drivers/thermal/k3_bandgap.c
+++ b/drivers/thermal/k3_bandgap.c
@@ -225,7 +225,6 @@ static int k3_bandgap_probe(struct platform_device *pdev)
devm_thermal_add_hwmon_sysfs(dev, data[id].tzd);
}
- platform_set_drvdata(pdev, bgp);
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] thermal: k3_bandgap: remove unneeded call to platform_set_drvdata()
2023-08-10 11:23 [PATCH] thermal: k3_bandgap: remove unneeded call to platform_set_drvdata() Andrei Coardos
@ 2023-08-11 5:59 ` Alexandru Ardelean
2023-08-16 10:19 ` Daniel Lezcano
1 sibling, 0 replies; 3+ messages in thread
From: Alexandru Ardelean @ 2023-08-11 5:59 UTC (permalink / raw)
To: Andrei Coardos
Cc: linux-kernel, linux-pm, rui.zhang, amitk, daniel.lezcano, rafael
On Thu, Aug 10, 2023 at 2:23 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
> drivers/thermal/k3_bandgap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/thermal/k3_bandgap.c b/drivers/thermal/k3_bandgap.c
> index 1c3e590157ec..f985f36f2123 100644
> --- a/drivers/thermal/k3_bandgap.c
> +++ b/drivers/thermal/k3_bandgap.c
> @@ -225,7 +225,6 @@ static int k3_bandgap_probe(struct platform_device *pdev)
> devm_thermal_add_hwmon_sysfs(dev, data[id].tzd);
> }
>
> - platform_set_drvdata(pdev, bgp);
>
> return 0;
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] thermal: k3_bandgap: remove unneeded call to platform_set_drvdata()
2023-08-10 11:23 [PATCH] thermal: k3_bandgap: remove unneeded call to platform_set_drvdata() Andrei Coardos
2023-08-11 5:59 ` Alexandru Ardelean
@ 2023-08-16 10:19 ` Daniel Lezcano
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Lezcano @ 2023-08-16 10:19 UTC (permalink / raw)
To: Andrei Coardos, linux-kernel, linux-pm; +Cc: rui.zhang, amitk, rafael, alex
On 10/08/2023 13:23, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-16 10:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-10 11:23 [PATCH] thermal: k3_bandgap: remove unneeded call to platform_set_drvdata() Andrei Coardos
2023-08-11 5:59 ` Alexandru Ardelean
2023-08-16 10:19 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox