Re: [PATCH] xhci: Keep interrupt disabled in initialization until host is running.

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Sep 22, 2023 at 04:03:26PM +0530, Prashanth K wrote:
> 
> 
> On 22-09-23 04:00 pm, Greg Kroah-Hartman wrote:
> > On Fri, Sep 22, 2023 at 02:51:41PM +0530, Prashanth K wrote:
> > > From: Hongyu Xie <xy521521@gmail.com>
> > > 
> > > [ Upstream commit 808925075fb750804a60ff0710614466c396db4 ]
> > > 
> > > irq is disabled in xhci_quiesce(called by xhci_halt, with bit:2 cleared
> > > in USBCMD register), but xhci_run(called by usb_add_hcd) re-enable it.
> > > It's possible that you will receive thousands of interrupt requests
> > > after initialization for 2.0 roothub. And you will get a lot of
> > > warning like, "xHCI dying, ignoring interrupt. Shouldn't IRQs be
> > > disabled?". This amount of interrupt requests will cause the entire
> > > system to freeze.
> > > This problem was first found on a device with ASM2142 host controller
> > > on it.
> > > 
> > > [tidy up old code while moving it, reword header -Mathias]
> > > 
> > > Cc: stable@kernel.org
> > > Signed-off-by: Hongyu Xie <xiehongyu1@kylinos.cn>
> > > Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> > > Link: https://lore.kernel.org/r/20220623111945.1557702-2-mathias.nyman@linux.intel.com
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > ---
> > >   drivers/usb/host/xhci.c | 34 +++++++++++++++++++++-------------
> > >   1 file changed, 21 insertions(+), 13 deletions(-)
> > 
> > What stable kernel(s) are you asking this to be applied to?
> > 
> > greg k-h
> Need this patch on v5.15, I had cc'ed "stable@kernel.org # 5.15", but looks
> like it didn't work. Should I resend this with SOB and CC tags?

Yes please.

thanks,

greg k-h