From: Bjorn Helgaas <helgaas@kernel.org>
To: Martin Mares <mj@ucw.cz>
Cc: "Pali Rohár" <pali@kernel.org>,
"Gustavo Pimentel" <Gustavo.Pimentel@synopsys.com>,
"Mateusz Nowicki" <mateusz.nowicki@solidigm.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: [PATCH 1/8] lspci: Reorder PCIe DevCtl2 fields to match spec
Date: Wed, 18 Oct 2023 11:08:29 -0500 [thread overview]
Message-ID: <20231018160836.1361510-2-helgaas@kernel.org> (raw)
In-Reply-To: <20231018160836.1361510-1-helgaas@kernel.org>
From: Bjorn Helgaas <bhelgaas@google.com>
Decode the PCIe DevCtl2 fields in the same order they're documented in the
PCIe spec.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
ls-caps.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/ls-caps.c b/ls-caps.c
index 1b63262ef005..beb7446a926e 100644
--- a/ls-caps.c
+++ b/ls-caps.c
@@ -1153,12 +1153,9 @@ static void cap_express_dev2(struct device *d, int where, int type)
}
w = get_conf_word(d, where + PCI_EXP_DEVCTL2);
- printf("\t\tDevCtl2: Completion Timeout: %s, TimeoutDis%c LTR%c 10BitTagReq%c OBFF %s,",
+ printf("\t\tDevCtl2: Completion Timeout: %s, TimeoutDis%c",
cap_express_dev2_timeout_value(PCI_EXP_DEVCTL2_TIMEOUT_VALUE(w)),
- FLAG(w, PCI_EXP_DEVCTL2_TIMEOUT_DIS),
- FLAG(w, PCI_EXP_DEVCTL2_LTR),
- FLAG(w, PCI_EXP_DEVCTL2_10BIT_TAG_REQ),
- cap_express_devctl2_obff(PCI_EXP_DEVCTL2_OBFF(w)));
+ FLAG(w, PCI_EXP_DEVCTL2_TIMEOUT_DIS));
if (type == PCI_EXP_TYPE_ROOT_PORT || type == PCI_EXP_TYPE_DOWNSTREAM)
printf(" ARIFwd%c\n", FLAG(w, PCI_EXP_DEVCTL2_ARI));
else
@@ -1176,6 +1173,10 @@ static void cap_express_dev2(struct device *d, int where, int type)
printf(" EgressBlck%c", FLAG(w, PCI_EXP_DEVCTL2_ATOMICOP_EGRESS_BLOCK));
printf("\n");
}
+ printf("\t\t\t LTR%c 10BitTagReq%c OBFF %s\n",
+ FLAG(w, PCI_EXP_DEVCTL2_LTR),
+ FLAG(w, PCI_EXP_DEVCTL2_10BIT_TAG_REQ),
+ cap_express_devctl2_obff(PCI_EXP_DEVCTL2_OBFF(w)));
}
static const char *cap_express_link2_speed_cap(int vector)
--
2.34.1
next prev parent reply other threads:[~2023-10-18 16:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 16:08 [PATCH 0/8] lspci: Decode more DevCtl2 fields Bjorn Helgaas
2023-10-18 16:08 ` Bjorn Helgaas [this message]
2023-10-18 16:08 ` [PATCH 2/8] lspci: Decode PCIe DevCtl2 ID-Based Ordering Enables Bjorn Helgaas
2023-10-18 16:08 ` [PATCH 3/8] lspci: Decode PCIe DevCtl2 Emergency Power Reduction Request Bjorn Helgaas
2023-10-18 16:08 ` [PATCH 4/8] lspci: Decode PCIe DevCtl2 End-to-End TLP Prefix Blocking Bjorn Helgaas
2023-10-18 16:08 ` [PATCH 5/8] lspci: Decode PCIe LnkCtl Link Disable as 'LnkDisable' Bjorn Helgaas
2023-10-18 16:08 ` [PATCH 6/8] lspci: Print PCIe Interrupt Message Numbers consistently Bjorn Helgaas
2023-10-18 16:08 ` [PATCH 7/8] lspci: Remove spurious colon (':') from PCIe PTM decoding Bjorn Helgaas
2023-10-18 16:08 ` [PATCH 8/8] setpci: Fix man page typo Bjorn Helgaas
2023-10-18 18:57 ` [PATCH 0/8] lspci: Decode more DevCtl2 fields Martin Mareš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018160836.1361510-2-helgaas@kernel.org \
--to=helgaas@kernel.org \
--cc=Gustavo.Pimentel@synopsys.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mateusz.nowicki@solidigm.com \
--cc=mj@ucw.cz \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox