* drivers/net/wireless/realtek/rtw89/coex.c:1448:17: warning: writing 8 bytes into a region of size 0
@ 2023-10-30 11:48 kernel test robot
2023-11-02 0:46 ` Ping-Ke Shih
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2023-10-30 11:48 UTC (permalink / raw)
To: Ping-Ke Shih; +Cc: oe-kbuild-all, linux-kernel, Kalle Valo
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: ffc253263a1375a65fa6c9f62a893e9767fbebfa
commit: 1fc4a874ff02ba8c07f8abf97c0bef686406f6df wifi: rtw89: coex: use new introduction BTC version format
date: 10 months ago
config: arm64-randconfig-r013-20221025 (https://download.01.org/0day-ci/archive/20231030/202310301908.Wrj0diqe-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231030/202310301908.Wrj0diqe-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310301908.Wrj0diqe-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/wireless/realtek/rtw89/coex.c: In function '_append_tdma':
>> drivers/net/wireless/realtek/rtw89/coex.c:1448:17: warning: writing 8 bytes into a region of size 0 [-Wstringop-overflow=]
1448 | memcpy(v, &dm->tdma, sizeof(*v));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/net/wireless/realtek/rtw89/coex.h:8,
from drivers/net/wireless/realtek/rtw89/coex.c:5:
drivers/net/wireless/realtek/rtw89/core.h:2049:37: note: at offset [4782, 70317] into destination object 'ver' of size 8
2049 | const struct rtw89_btc_ver *ver;
| ^~~
vim +1448 drivers/net/wireless/realtek/rtw89/coex.c
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1423
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1424 static void _append_tdma(struct rtw89_dev *rtwdev)
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1425 {
ce986f3dc4fc69 Ching-Te Ku 2022-07-25 1426 const struct rtw89_chip_info *chip = rtwdev->chip;
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1427 struct rtw89_btc *btc = &rtwdev->btc;
1fc4a874ff02ba Ping-Ke Shih 2022-12-17 1428 const struct rtw89_btc_ver *ver = btc->ver;
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1429 struct rtw89_btc_dm *dm = &btc->dm;
ce986f3dc4fc69 Ching-Te Ku 2022-07-25 1430 struct rtw89_btc_btf_tlv *tlv;
ce986f3dc4fc69 Ching-Te Ku 2022-07-25 1431 struct rtw89_btc_fbtc_tdma *v;
ce986f3dc4fc69 Ching-Te Ku 2022-07-25 1432 struct rtw89_btc_fbtc_tdma_v1 *v1;
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1433 u16 len = btc->policy_len;
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1434
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1435 if (!btc->update_policy_force &&
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1436 !memcmp(&dm->tdma, &dm->tdma_now, sizeof(dm->tdma))) {
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1437 rtw89_debug(rtwdev,
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1438 RTW89_DBG_BTC, "[BTC], %s(): tdma no change!\n",
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1439 __func__);
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1440 return;
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1441 }
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1442
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1443 tlv = (struct rtw89_btc_btf_tlv *)&btc->policy[len];
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1444 tlv->type = CXPOLICY_TDMA;
ce986f3dc4fc69 Ching-Te Ku 2022-07-25 1445 if (chip->chip_id == RTL8852A) {
ce986f3dc4fc69 Ching-Te Ku 2022-07-25 1446 v = (struct rtw89_btc_fbtc_tdma *)&tlv->val[0];
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1447 tlv->len = sizeof(*v);
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 @1448 memcpy(v, &dm->tdma, sizeof(*v));
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1449 btc->policy_len += BTC_TLV_HDR_LEN + sizeof(*v);
ce986f3dc4fc69 Ching-Te Ku 2022-07-25 1450 } else {
ce986f3dc4fc69 Ching-Te Ku 2022-07-25 1451 tlv->len = sizeof(*v1);
ce986f3dc4fc69 Ching-Te Ku 2022-07-25 1452 v1 = (struct rtw89_btc_fbtc_tdma_v1 *)&tlv->val[0];
1fc4a874ff02ba Ping-Ke Shih 2022-12-17 1453 v1->fver = ver->fcxtdma;
ce986f3dc4fc69 Ching-Te Ku 2022-07-25 1454 v1->tdma = dm->tdma;
ce986f3dc4fc69 Ching-Te Ku 2022-07-25 1455 btc->policy_len += BTC_TLV_HDR_LEN + sizeof(*v1);
ce986f3dc4fc69 Ching-Te Ku 2022-07-25 1456 }
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1457
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1458 rtw89_debug(rtwdev, RTW89_DBG_BTC,
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1459 "[BTC], %s(): type:%d, rxflctrl=%d, txpause=%d, wtgle_n=%d, leak_n=%d, ext_ctrl=%d\n",
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1460 __func__, dm->tdma.type, dm->tdma.rxflctrl,
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1461 dm->tdma.txpause, dm->tdma.wtgle_n, dm->tdma.leak_n,
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1462 dm->tdma.ext_ctrl);
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1463 }
e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1464
:::::: The code at line 1448 was first introduced by commit
:::::: e3ec7017f6a20d12ddd9fe23d345ebb7b8c104dd rtw89: add Realtek 802.11ax driver
:::::: TO: Ping-Ke Shih <pkshih@realtek.com>
:::::: CC: Kalle Valo <kvalo@codeaurora.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* RE: drivers/net/wireless/realtek/rtw89/coex.c:1448:17: warning: writing 8 bytes into a region of size 0
2023-10-30 11:48 drivers/net/wireless/realtek/rtw89/coex.c:1448:17: warning: writing 8 bytes into a region of size 0 kernel test robot
@ 2023-11-02 0:46 ` Ping-Ke Shih
0 siblings, 0 replies; 2+ messages in thread
From: Ping-Ke Shih @ 2023-11-02 0:46 UTC (permalink / raw)
To: kernel test robot
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Kalle Valo
> -----Original Message-----
> From: kernel test robot <lkp@intel.com>
> Sent: Monday, October 30, 2023 7:48 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: oe-kbuild-all@lists.linux.dev; linux-kernel@vger.kernel.org; Kalle Valo <kvalo@kernel.org>
> Subject: drivers/net/wireless/realtek/rtw89/coex.c:1448:17: warning: writing 8 bytes into a region of size
> 0
drivers/net/wireless/realtek/rtw89/coex.c: In function '_append_tdma':
>> drivers/net/wireless/realtek/rtw89/coex.c:1448:17: warning: writing 8 bytes into a region of size 0 [-Wstringop-overflow=]
1448 | memcpy(v, &dm->tdma, sizeof(*v));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1442
> e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1443 tlv = (struct rtw89_btc_btf_tlv *)&btc->policy[len];
> e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1444 tlv->type = CXPOLICY_TDMA;
> ce986f3dc4fc69 Ching-Te Ku 2022-07-25 1445 if (chip->chip_id == RTL8852A) {
> ce986f3dc4fc69 Ching-Te Ku 2022-07-25 1446 v = (struct rtw89_btc_fbtc_tdma *)&tlv->val[0];
> e3ec7017f6a20d Ping-Ke Shih 2021-10-11 1447 tlv->len = sizeof(*v);
> e3ec7017f6a20d Ping-Ke Shih 2021-10-11 @1448 memcpy(v, &dm->tdma, sizeof(*v));
This statement is to append a struct named rtw89_btc_fbtc_tdma to value field of
a TLV struct, but compiler warns dst of memcpy() because of tlv->val[]. Maybe,
this is a false alarm?
Anyway, for this case, a simple assignment "*v = dm->tdma;" would be easier to
understand what it wants and also avoid compiler warnings. Then, I sent a
patch [1] for this.
[1] https://lore.kernel.org/linux-wireless/20231102003716.25815-1-pkshih@realtek.com/T/#u
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-02 0:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-30 11:48 drivers/net/wireless/realtek/rtw89/coex.c:1448:17: warning: writing 8 bytes into a region of size 0 kernel test robot
2023-11-02 0:46 ` Ping-Ke Shih
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox