* Re: [PATCH v2] serial: 8250: 8250_omap: Clear UART_HAS_RHR_IT_DIS bit
2023-10-31 10:20 [PATCH v2] serial: 8250: 8250_omap: Clear UART_HAS_RHR_IT_DIS bit Ronald Wahl
@ 2023-10-31 10:47 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2023-10-31 10:47 UTC (permalink / raw)
To: Ronald Wahl; +Cc: linux-kernel, linux-serial, Vignesh Raghavendra, Ronald Wahl
On Tue, Oct 31, 2023 at 11:20:24AM +0100, Ronald Wahl wrote:
> From: Ronald Wahl <ronald.wahl@raritan.com>
>
> This fixes commit 439c7183e5b9 ("serial: 8250: 8250_omap: Disable RX
> interrupt after DMA enable") which unfortunately set the
> UART_HAS_RHR_IT_DIS bit in the UART_OMAP_IER2 register and never
> cleared it.
>
> Fixes: 439c7183e5b9 ("serial: 8250: 8250_omap: Disable RX interrupt after DMA enable")
> Signed-off-by: Ronald Wahl <ronald.wahl@raritan.com>
> ---
> V2: - add Fixes: tag
> - fix author
>
> drivers/tty/serial/8250/8250_omap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
> index ca972fd37725..c7ab2963040b 100644
> --- a/drivers/tty/serial/8250/8250_omap.c
> +++ b/drivers/tty/serial/8250/8250_omap.c
> @@ -914,7 +914,7 @@ static void __dma_rx_do_complete(struct uart_8250_port *p)
> if (priv->habit & UART_HAS_RHR_IT_DIS) {
> reg = serial_in(p, UART_OMAP_IER2);
> reg &= ~UART_OMAP_IER2_RHR_IT_DIS;
> - serial_out(p, UART_OMAP_IER2, UART_OMAP_IER2_RHR_IT_DIS);
> + serial_out(p, UART_OMAP_IER2, reg);
> }
>
> dmaengine_tx_status(rxchan, cookie, &state);
> @@ -1060,7 +1060,7 @@ static int omap_8250_rx_dma(struct uart_8250_port *p)
> if (priv->habit & UART_HAS_RHR_IT_DIS) {
> reg = serial_in(p, UART_OMAP_IER2);
> reg |= UART_OMAP_IER2_RHR_IT_DIS;
> - serial_out(p, UART_OMAP_IER2, UART_OMAP_IER2_RHR_IT_DIS);
> + serial_out(p, UART_OMAP_IER2, reg);
> }
>
> dma_async_issue_pending(dma->rxchan);
> --
> 2.41.0
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You have marked a patch with a "Fixes:" tag for a commit that is in an
older released kernel, yet you do not have a cc: stable line in the
signed-off-by area at all, which means that the patch will not be
applied to any older kernel releases. To properly fix this, please
follow the documented rules in the
Documentation/process/stable-kernel-rules.rst file for how to resolve
this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 2+ messages in thread