* [PATCH -next] platform/mellanox: Simplify bool conversion
@ 2023-11-21 0:55 Yang Li
2023-11-21 7:59 ` Ilpo Järvinen
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2023-11-21 0:55 UTC (permalink / raw)
To: hdegoede, ilpo.jarvinen, markgross, vadimp
Cc: platform-driver-x86, linux-kernel, Yang Li, Abaci Robot
./drivers/platform/mellanox/mlxbf-tmfifo.c:94:41-46: WARNING: conversion to bool not needed here
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7584
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/platform/mellanox/mlxbf-tmfifo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c b/drivers/platform/mellanox/mlxbf-tmfifo.c
index 5c683b4eaf10..8ba23eb5be0b 100644
--- a/drivers/platform/mellanox/mlxbf-tmfifo.c
+++ b/drivers/platform/mellanox/mlxbf-tmfifo.c
@@ -91,7 +91,7 @@ struct mlxbf_tmfifo_vring {
/* Check whether vring is in drop mode. */
#define IS_VRING_DROP(_r) ({ \
typeof(_r) (r) = (_r); \
- (r->desc_head == &r->drop_desc ? true : false); })
+ (r->desc_head == &r->drop_desc); })
/* A stub length to drop maximum length packet. */
#define VRING_DROP_DESC_MAX_LEN GENMASK(15, 0)
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] platform/mellanox: Simplify bool conversion
2023-11-21 0:55 [PATCH -next] platform/mellanox: Simplify bool conversion Yang Li
@ 2023-11-21 7:59 ` Ilpo Järvinen
0 siblings, 0 replies; 2+ messages in thread
From: Ilpo Järvinen @ 2023-11-21 7:59 UTC (permalink / raw)
To: Yang Li
Cc: Hans de Goede, markgross, vadimp, platform-driver-x86, LKML,
Abaci Robot
On Tue, 21 Nov 2023, Yang Li wrote:
> ./drivers/platform/mellanox/mlxbf-tmfifo.c:94:41-46: WARNING: conversion to bool not needed here
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7584
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Thank you for your patch.
This is already fixed by the commit 57eb82ff34e3 ("platform/mellanox:
mlxbf-tmfifo: Remove unnecessary bool conversion") that is currently
queued in pdf86.git/review-hans branch.
Also, next time write a better changelog, it's not enough to just quote
an error message.
--
i.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-21 7:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-21 0:55 [PATCH -next] platform/mellanox: Simplify bool conversion Yang Li
2023-11-21 7:59 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox