* drivers/misc/xilinx_sdfec.c:92:57: warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 6
@ 2023-12-26 5:56 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-12-26 5:56 UTC (permalink / raw)
To: Dragan Cvetic; +Cc: oe-kbuild-all, linux-kernel, Derek Kiernan
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: fbafc3e621c3f4ded43720fdb1d6ce1728ec664e
commit: 76d83e1c32334a793e50de6f955c2eefcc60bb8e misc: xilinx-sdfec: add core driver
date: 4 years, 6 months ago
config: sparc64-randconfig-r025-20230806 (https://download.01.org/0day-ci/archive/20231226/202312261345.5icSobz6-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20231226/202312261345.5icSobz6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312261345.5icSobz6-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/misc/xilinx_sdfec.c: In function 'xsdfec_probe':
>> drivers/misc/xilinx_sdfec.c:92:57: warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 6 [-Wformat-truncation=]
92 | snprintf(xsdfec->dev_name, DEV_NAME_LEN, "xsdfec%d", xsdfec->dev_id);
| ^~
drivers/misc/xilinx_sdfec.c:92:50: note: directive argument in the range [0, 2147483647]
92 | snprintf(xsdfec->dev_name, DEV_NAME_LEN, "xsdfec%d", xsdfec->dev_id);
| ^~~~~~~~~~
drivers/misc/xilinx_sdfec.c:92:9: note: 'snprintf' output between 8 and 17 bytes into a destination of size 12
92 | snprintf(xsdfec->dev_name, DEV_NAME_LEN, "xsdfec%d", xsdfec->dev_id);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for COMPAT_BINFMT_ELF
Depends on [n]: COMPAT [=y] && BINFMT_ELF [=n]
Selected by [y]:
- COMPAT [=y] && SPARC64 [=y]
vim +92 drivers/misc/xilinx_sdfec.c
59
60 static int xsdfec_probe(struct platform_device *pdev)
61 {
62 struct xsdfec_dev *xsdfec;
63 struct device *dev;
64 struct resource *res;
65 int err;
66
67 xsdfec = devm_kzalloc(&pdev->dev, sizeof(*xsdfec), GFP_KERNEL);
68 if (!xsdfec)
69 return -ENOMEM;
70
71 xsdfec->dev = &pdev->dev;
72 spin_lock_init(&xsdfec->error_data_lock);
73
74 dev = xsdfec->dev;
75 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
76 xsdfec->regs = devm_ioremap_resource(dev, res);
77 if (IS_ERR(xsdfec->regs)) {
78 err = PTR_ERR(xsdfec->regs);
79 return err;
80 }
81
82 /* Save driver private data */
83 platform_set_drvdata(pdev, xsdfec);
84
85 mutex_lock(&dev_idr_lock);
86 err = idr_alloc(&dev_idr, xsdfec->dev_name, 0, 0, GFP_KERNEL);
87 mutex_unlock(&dev_idr_lock);
88 if (err < 0)
89 goto err_xsddev_idr;
90 xsdfec->dev_id = err;
91
> 92 snprintf(xsdfec->dev_name, DEV_NAME_LEN, "xsdfec%d", xsdfec->dev_id);
93 xsdfec->miscdev.minor = MISC_DYNAMIC_MINOR;
94 xsdfec->miscdev.name = xsdfec->dev_name;
95 xsdfec->miscdev.fops = &xsdfec_fops;
96 xsdfec->miscdev.parent = dev;
97 err = misc_register(&xsdfec->miscdev);
98 if (err) {
99 dev_err(dev, "error:%d. Unable to register device", err);
100 return err;
101 }
102 return 0;
103
104 err_xsddev_idr:
105 xsdfec_idr_remove(xsdfec);
106
107 return err;
108 }
109
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* drivers/misc/xilinx_sdfec.c:92:57: warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 6
@ 2024-12-22 11:08 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-12-22 11:08 UTC (permalink / raw)
To: Dragan Cvetic; +Cc: oe-kbuild-all, linux-kernel, Derek Kiernan
Hi Dragan,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 48f506ad0b683d3e7e794efa60c5785c4fdc86fa
commit: 76d83e1c32334a793e50de6f955c2eefcc60bb8e misc: xilinx-sdfec: add core driver
date: 6 years ago
config: sparc-randconfig-001-20241212 (https://download.01.org/0day-ci/archive/20241222/202412221944.uWX2XEkG-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241222/202412221944.uWX2XEkG-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412221944.uWX2XEkG-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/misc/xilinx_sdfec.c: In function 'xsdfec_probe':
>> drivers/misc/xilinx_sdfec.c:92:57: warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 6 [-Wformat-truncation=]
92 | snprintf(xsdfec->dev_name, DEV_NAME_LEN, "xsdfec%d", xsdfec->dev_id);
| ^~
drivers/misc/xilinx_sdfec.c:92:50: note: directive argument in the range [0, 2147483647]
92 | snprintf(xsdfec->dev_name, DEV_NAME_LEN, "xsdfec%d", xsdfec->dev_id);
| ^~~~~~~~~~
drivers/misc/xilinx_sdfec.c:92:9: note: 'snprintf' output between 8 and 17 bytes into a destination of size 12
92 | snprintf(xsdfec->dev_name, DEV_NAME_LEN, "xsdfec%d", xsdfec->dev_id);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +92 drivers/misc/xilinx_sdfec.c
59
60 static int xsdfec_probe(struct platform_device *pdev)
61 {
62 struct xsdfec_dev *xsdfec;
63 struct device *dev;
64 struct resource *res;
65 int err;
66
67 xsdfec = devm_kzalloc(&pdev->dev, sizeof(*xsdfec), GFP_KERNEL);
68 if (!xsdfec)
69 return -ENOMEM;
70
71 xsdfec->dev = &pdev->dev;
72 spin_lock_init(&xsdfec->error_data_lock);
73
74 dev = xsdfec->dev;
75 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
76 xsdfec->regs = devm_ioremap_resource(dev, res);
77 if (IS_ERR(xsdfec->regs)) {
78 err = PTR_ERR(xsdfec->regs);
79 return err;
80 }
81
82 /* Save driver private data */
83 platform_set_drvdata(pdev, xsdfec);
84
85 mutex_lock(&dev_idr_lock);
86 err = idr_alloc(&dev_idr, xsdfec->dev_name, 0, 0, GFP_KERNEL);
87 mutex_unlock(&dev_idr_lock);
88 if (err < 0)
89 goto err_xsddev_idr;
90 xsdfec->dev_id = err;
91
> 92 snprintf(xsdfec->dev_name, DEV_NAME_LEN, "xsdfec%d", xsdfec->dev_id);
93 xsdfec->miscdev.minor = MISC_DYNAMIC_MINOR;
94 xsdfec->miscdev.name = xsdfec->dev_name;
95 xsdfec->miscdev.fops = &xsdfec_fops;
96 xsdfec->miscdev.parent = dev;
97 err = misc_register(&xsdfec->miscdev);
98 if (err) {
99 dev_err(dev, "error:%d. Unable to register device", err);
100 return err;
101 }
102 return 0;
103
104 err_xsddev_idr:
105 xsdfec_idr_remove(xsdfec);
106
107 return err;
108 }
109
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-22 11:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-26 5:56 drivers/misc/xilinx_sdfec.c:92:57: warning: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 6 kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2024-12-22 11:08 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox