* [PATCH] hwmon: (lm75) Fix tmp112 default config
@ 2024-01-06 3:02 Abdel Alkuor
2024-01-08 15:26 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Abdel Alkuor @ 2024-01-06 3:02 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck, Iker Perez del Palomar Sustatxa
Cc: Abdel Alkuor, linux-hwmon, linux-kernel
Set tmp112 conversion rate to 8 HZ and 12-bit mode.
Fixes: 35cd18048542 ("hwmon: (lm75) Aproximate sample times to data-sheet values")
Signed-off-by: Abdel Alkuor <alkuor@gmail.com>
---
drivers/hwmon/lm75.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
index d3b0d8bf1654..e00750718536 100644
--- a/drivers/hwmon/lm75.c
+++ b/drivers/hwmon/lm75.c
@@ -269,8 +269,9 @@ static const struct lm75_params device_params[] = {
.resolutions = (u8 []) {9, 10, 11, 12 },
},
[tmp112] = {
- .set_mask = 3 << 5, /* 8 samples / second */
- .clr_mask = 1 << 7, /* no one-shot mode*/
+ .config_reg_16bits = true,
+ .set_mask = 0x60C0, /* 12-bit mode, 8 samples / second */
+ .clr_mask = 1 << 15, /* no one-shot mode*/
.default_resolution = 12,
.default_sample_time = 125,
.num_sample_times = 4,
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: (lm75) Fix tmp112 default config
2024-01-06 3:02 [PATCH] hwmon: (lm75) Fix tmp112 default config Abdel Alkuor
@ 2024-01-08 15:26 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2024-01-08 15:26 UTC (permalink / raw)
To: Abdel Alkuor
Cc: Jean Delvare, Iker Perez del Palomar Sustatxa, linux-hwmon,
linux-kernel
On Fri, Jan 05, 2024 at 10:02:53PM -0500, Abdel Alkuor wrote:
> Set tmp112 conversion rate to 8 HZ and 12-bit mode.
>
> Fixes: 35cd18048542 ("hwmon: (lm75) Aproximate sample times to data-sheet values")
> Signed-off-by: Abdel Alkuor <alkuor@gmail.com>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-08 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-06 3:02 [PATCH] hwmon: (lm75) Fix tmp112 default config Abdel Alkuor
2024-01-08 15:26 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox