From: Juri Lelli <juri.lelli@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
Aaron Tomlin <atomlin@atomlin.com>,
Valentin Schneider <vschneid@redhat.com>,
Waiman Long <longman@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH 0/4] Fix handling of rescuers affinity
Date: Tue, 16 Jan 2024 17:19:25 +0100 [thread overview]
Message-ID: <20240116161929.232885-1-juri.lelli@redhat.com> (raw)
Hello,
Recently I've been pointed at the fact that workqueue rescuers seem not
to follow unbound workqueues cpumask changes. This small series is a
first stab at possibly fixing what I considered to be different from
what I expected (it might very well be the case that my expectations are
wrong :). Long story short, it seems to me that we currently have
several cases where a change of the general unbound cpumask or a change
of the per-workqueue cpumask (for WQ_SYSFS workqueues) is not reflected
into the corresponding rescuer affinity (if a rescuer is present).
In the following:
Patch 01/04 - Adds debug information to wq_dump.py script so that we
can more easily check workqueues and rescuers cpumasks
02/04 - Fixes cpumask discrepancies when rescuers are created
03/04 - Streamlines behavior of general unbound vs. WQ_SYSFS
cpumask changes
04/04 - Makes sure existing rescuers affinity follows their
workqueue cpumask changes
Please take a look, I'm all for feedback and better understanding of the
details I'm certainly missing.
For additional context, a related discussion can be found at
https://lore.kernel.org/lkml/um77hym4t6zyypfbhwbaeqxpfdzc657oa7vgowdfah7cuctjak@pexots3mfb24/
Branch for testing available at
git@github.com:jlelli/linux.git workqueue/rescuers-cpumask
Best,
Juri
Juri Lelli (4):
workqueue: Add rescuers printing to wq_dump.py
kernel/workqueue: Bind rescuer to unbound cpumask for WQ_UNBOUND
kernel/workqueue: Distinguish between general unbound and WQ_SYSFS
cpumask changes
kernel/workqueue: Let rescuers follow unbound wq cpumask changes
kernel/workqueue.c | 28 +++++++++++++++++++++-------
tools/workqueue/wq_dump.py | 29 +++++++++++++++++++++++++++++
2 files changed, 50 insertions(+), 7 deletions(-)
--
2.43.0
next reply other threads:[~2024-01-16 16:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 16:19 Juri Lelli [this message]
2024-01-16 16:19 ` [RFC PATCH 1/4] tools/workqueue: Add rescuers printing to wq_dump.py Juri Lelli
2024-01-16 16:19 ` [RFC PATCH 2/4] kernel/workqueue: Bind rescuer to unbound cpumask for WQ_UNBOUND Juri Lelli
2024-01-16 18:47 ` Tejun Heo
2024-01-17 6:30 ` Juri Lelli
2024-01-16 16:19 ` [RFC PATCH 3/4] kernel/workqueue: Distinguish between general unbound and WQ_SYSFS cpumask changes Juri Lelli
2024-01-16 18:57 ` Tejun Heo
2024-01-17 13:06 ` Juri Lelli
2024-01-17 17:12 ` Tejun Heo
2024-01-17 19:32 ` Waiman Long
2024-01-17 19:42 ` Tejun Heo
2024-01-18 12:52 ` Juri Lelli
2024-01-16 16:19 ` [RFC PATCH 4/4] kernel/workqueue: Let rescuers follow unbound wq " Juri Lelli
2024-01-17 3:56 ` Lai Jiangshan
2024-01-17 6:30 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116161929.232885-1-juri.lelli@redhat.com \
--to=juri.lelli@redhat.com \
--cc=atomlin@atomlin.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=tj@kernel.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox