* [PATCH -next] efi/libstub: Add one kernel-doc comment
@ 2024-01-19 10:06 Yang Li
2024-01-19 11:42 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2024-01-19 10:06 UTC (permalink / raw)
To: ardb; +Cc: linux-efi, linux-kernel, Yang Li
Add the description of @memory_type to silence the warning:
drivers/firmware/efi/libstub/alignedmem.c:27: warning: Function parameter or struct member 'memory_type' not described in 'efi_allocate_pages_aligned'
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/firmware/efi/libstub/alignedmem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/efi/libstub/alignedmem.c b/drivers/firmware/efi/libstub/alignedmem.c
index 6b83c492c3b8..8ff51c6a2aa1 100644
--- a/drivers/firmware/efi/libstub/alignedmem.c
+++ b/drivers/firmware/efi/libstub/alignedmem.c
@@ -14,6 +14,7 @@
* @max: the address that the last allocated memory page shall not
* exceed
* @align: minimum alignment of the base of the allocation
+ * @memory_type: the type of memory to allocate, as defined by efi_memory_type
*
* Allocate pages as EFI_LOADER_DATA. The allocated pages are aligned according
* to @align, which should be >= EFI_ALLOC_ALIGN. The last allocated page will
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] efi/libstub: Add one kernel-doc comment
2024-01-19 10:06 [PATCH -next] efi/libstub: Add one kernel-doc comment Yang Li
@ 2024-01-19 11:42 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2024-01-19 11:42 UTC (permalink / raw)
To: Yang Li; +Cc: linux-efi, linux-kernel
On Fri, 19 Jan 2024 at 11:06, Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Add the description of @memory_type to silence the warning:
> drivers/firmware/efi/libstub/alignedmem.c:27: warning: Function parameter or struct member 'memory_type' not described in 'efi_allocate_pages_aligned'
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/firmware/efi/libstub/alignedmem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/efi/libstub/alignedmem.c b/drivers/firmware/efi/libstub/alignedmem.c
> index 6b83c492c3b8..8ff51c6a2aa1 100644
> --- a/drivers/firmware/efi/libstub/alignedmem.c
> +++ b/drivers/firmware/efi/libstub/alignedmem.c
> @@ -14,6 +14,7 @@
> * @max: the address that the last allocated memory page shall not
> * exceed
> * @align: minimum alignment of the base of the allocation
> + * @memory_type: the type of memory to allocate, as defined by efi_memory_type
What is 'efi_memory_type'?
> *
> * Allocate pages as EFI_LOADER_DATA. The allocated pages are aligned according
> * to @align, which should be >= EFI_ALLOC_ALIGN. The last allocated page will
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-19 11:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-19 10:06 [PATCH -next] efi/libstub: Add one kernel-doc comment Yang Li
2024-01-19 11:42 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox