From: Andrew Davis <afd@ti.com>
To: "Gerd Hoffmann" <kraxel@redhat.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"Paul Cercueil" <paul@crapouillou.net>
Cc: <dri-devel@lists.freedesktop.org>, <linux-media@vger.kernel.org>,
<linaro-mm-sig@lists.linaro.org>, <linux-kernel@vger.kernel.org>,
Andrew Davis <afd@ti.com>
Subject: [PATCH 1/3] udmabuf: Keep track current device mappings
Date: Tue, 23 Jan 2024 16:12:25 -0600 [thread overview]
Message-ID: <20240123221227.868341-1-afd@ti.com> (raw)
When a device attaches to and maps our buffer we need to keep track
of this mapping/device. This is needed for synchronization with these
devices when beginning and ending CPU access for instance. Add a list
that tracks device mappings as part of {map,unmap}_udmabuf().
Signed-off-by: Andrew Davis <afd@ti.com>
---
drivers/dma-buf/udmabuf.c | 43 +++++++++++++++++++++++++++++++++++++--
1 file changed, 41 insertions(+), 2 deletions(-)
diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c
index c406459996489..3a23f0a7d112a 100644
--- a/drivers/dma-buf/udmabuf.c
+++ b/drivers/dma-buf/udmabuf.c
@@ -28,6 +28,14 @@ struct udmabuf {
struct page **pages;
struct sg_table *sg;
struct miscdevice *device;
+ struct list_head attachments;
+ struct mutex lock;
+};
+
+struct udmabuf_attachment {
+ struct device *dev;
+ struct sg_table *table;
+ struct list_head list;
};
static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf)
@@ -120,14 +128,42 @@ static void put_sg_table(struct device *dev, struct sg_table *sg,
static struct sg_table *map_udmabuf(struct dma_buf_attachment *at,
enum dma_data_direction direction)
{
- return get_sg_table(at->dev, at->dmabuf, direction);
+ struct udmabuf *ubuf = at->dmabuf->priv;
+ struct udmabuf_attachment *a;
+
+ a = kzalloc(sizeof(*a), GFP_KERNEL);
+ if (!a)
+ return ERR_PTR(-ENOMEM);
+
+ a->table = get_sg_table(at->dev, at->dmabuf, direction);
+ if (IS_ERR(a->table)) {
+ kfree(a);
+ return a->table;
+ }
+
+ a->dev = at->dev;
+
+ mutex_lock(&ubuf->lock);
+ list_add(&a->list, &ubuf->attachments);
+ mutex_unlock(&ubuf->lock);
+
+ return a->table;
}
static void unmap_udmabuf(struct dma_buf_attachment *at,
struct sg_table *sg,
enum dma_data_direction direction)
{
- return put_sg_table(at->dev, sg, direction);
+ struct udmabuf_attachment *a = at->priv;
+ struct udmabuf *ubuf = at->dmabuf->priv;
+
+ mutex_lock(&ubuf->lock);
+ list_del(&a->list);
+ mutex_unlock(&ubuf->lock);
+
+ put_sg_table(at->dev, sg, direction);
+
+ kfree(a);
}
static void release_udmabuf(struct dma_buf *buf)
@@ -263,6 +299,9 @@ static long udmabuf_create(struct miscdevice *device,
memfd = NULL;
}
+ INIT_LIST_HEAD(&ubuf->attachments);
+ mutex_init(&ubuf->lock);
+
exp_info.ops = &udmabuf_ops;
exp_info.size = ubuf->pagecount << PAGE_SHIFT;
exp_info.priv = ubuf;
--
2.39.2
next reply other threads:[~2024-01-23 22:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 22:12 Andrew Davis [this message]
2024-01-23 22:12 ` [PATCH 2/3] udmabuf: Sync buffer mappings for attached devices Andrew Davis
2024-01-24 23:05 ` Kasireddy, Vivek
2024-01-25 15:45 ` Andrew Davis
2024-01-26 7:25 ` Kasireddy, Vivek
2024-01-26 17:40 ` Andrew Davis
2024-01-30 6:23 ` Kasireddy, Vivek
2024-01-25 20:30 ` [Linaro-mm-sig] " Daniel Vetter
2024-01-26 17:24 ` Andrew Davis
2024-01-29 12:27 ` Christian König
2024-01-23 22:12 ` [PATCH 3/3] udmabuf: Use module_misc_device() to register this device Andrew Davis
2024-01-24 22:37 ` Kasireddy, Vivek
2024-01-24 22:36 ` [PATCH 1/3] udmabuf: Keep track current device mappings Kasireddy, Vivek
2024-01-25 15:22 ` Andrew Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240123221227.868341-1-afd@ti.com \
--to=afd@ti.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox