* [PATCH] block: rbd: make rbd_bus_type const
@ 2024-02-04 15:31 Ricardo B. Marliere
2024-02-04 21:06 ` Alex Elder
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ricardo B. Marliere @ 2024-02-04 15:31 UTC (permalink / raw)
To: Ilya Dryomov, Dongsheng Yang, Jens Axboe
Cc: ceph-devel, linux-block, linux-kernel, Greg Kroah-Hartman,
Ricardo B. Marliere
Now that the driver core can properly handle constant struct bus_type,
move the rbd_bus_type variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
drivers/block/rbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 0202a4e5d6cf..21f2b9e9b9ff 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -575,7 +575,7 @@ static const struct attribute_group rbd_bus_group = {
};
__ATTRIBUTE_GROUPS(rbd_bus);
-static struct bus_type rbd_bus_type = {
+static const struct bus_type rbd_bus_type = {
.name = "rbd",
.bus_groups = rbd_bus_groups,
};
---
base-commit: aa826a9b19b93bf8aabc462381ae436a60b2a320
change-id: 20240204-bus_cleanup-block-9986bfea7975
Best regards,
--
Ricardo B. Marliere <ricardo@marliere.net>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] block: rbd: make rbd_bus_type const
2024-02-04 15:31 [PATCH] block: rbd: make rbd_bus_type const Ricardo B. Marliere
@ 2024-02-04 21:06 ` Alex Elder
2024-02-05 12:51 ` Greg Kroah-Hartman
2024-02-06 17:37 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Alex Elder @ 2024-02-04 21:06 UTC (permalink / raw)
To: Ricardo B. Marliere, Ilya Dryomov, Dongsheng Yang, Jens Axboe
Cc: ceph-devel, linux-block, linux-kernel, Greg Kroah-Hartman
On 2/4/24 9:31 AM, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the rbd_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
Great!
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> drivers/block/rbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 0202a4e5d6cf..21f2b9e9b9ff 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -575,7 +575,7 @@ static const struct attribute_group rbd_bus_group = {
> };
> __ATTRIBUTE_GROUPS(rbd_bus);
>
> -static struct bus_type rbd_bus_type = {
> +static const struct bus_type rbd_bus_type = {
> .name = "rbd",
> .bus_groups = rbd_bus_groups,
> };
>
> ---
> base-commit: aa826a9b19b93bf8aabc462381ae436a60b2a320
> change-id: 20240204-bus_cleanup-block-9986bfea7975
>
> Best regards,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] block: rbd: make rbd_bus_type const
2024-02-04 15:31 [PATCH] block: rbd: make rbd_bus_type const Ricardo B. Marliere
2024-02-04 21:06 ` Alex Elder
@ 2024-02-05 12:51 ` Greg Kroah-Hartman
2024-02-06 17:37 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2024-02-05 12:51 UTC (permalink / raw)
To: Ricardo B. Marliere
Cc: Ilya Dryomov, Dongsheng Yang, Jens Axboe, ceph-devel, linux-block,
linux-kernel
On Sun, Feb 04, 2024 at 12:31:42PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the rbd_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: rbd: make rbd_bus_type const
2024-02-04 15:31 [PATCH] block: rbd: make rbd_bus_type const Ricardo B. Marliere
2024-02-04 21:06 ` Alex Elder
2024-02-05 12:51 ` Greg Kroah-Hartman
@ 2024-02-06 17:37 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2024-02-06 17:37 UTC (permalink / raw)
To: Ilya Dryomov, Dongsheng Yang, Ricardo B. Marliere
Cc: ceph-devel, linux-block, linux-kernel, Greg Kroah-Hartman
On Sun, 04 Feb 2024 12:31:42 -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the rbd_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
>
Applied, thanks!
[1/1] block: rbd: make rbd_bus_type const
commit: 052618c71c66d5de5e9b6cbcbad26932d951919c
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-06 17:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-04 15:31 [PATCH] block: rbd: make rbd_bus_type const Ricardo B. Marliere
2024-02-04 21:06 ` Alex Elder
2024-02-05 12:51 ` Greg Kroah-Hartman
2024-02-06 17:37 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox