From: Eric Biggers <ebiggers@kernel.org>
To: Kshitiz Varshney <kshitiz.varshney@nxp.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Varun Sethi <V.Sethi@nxp.com>, Gaurav Jain <gaurav.jain@nxp.com>,
Pankaj Gupta <pankaj.gupta@nxp.com>,
Sahil Malhotra <sahil.malhotra@nxp.com>,
Vabhav Sharma <vabhav.sharma@nxp.com>,
Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>,
Rahul Kumar Yadav <rahulkumar.yadav@nxp.com>,
Nikhil Singla <nikhil.singla@nxp.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Enable config for sm3, sm4, polyval, xctr cipher test as built in module.
Date: Mon, 5 Feb 2024 12:19:20 -0800 [thread overview]
Message-ID: <20240205201920.GA2220@sol.localdomain> (raw)
In-Reply-To: <20240205112933.3084766-1-kshitiz.varshney@nxp.com>
On Mon, Feb 05, 2024 at 12:29:33PM +0100, Kshitiz Varshney wrote:
> Issue:-
> Multiple crypto tests like sm3, sm4 xctr and polyval failing.
>
> skcipher: failed to allocate transform for xctr(aes): -2
> alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
> alg: self-tests for sm3 using sm3 failed (rc=-2)
> tcrypt: failed to load transform for sm3: -2
> alg: hash: failed to allocate transform for polyval: -2
> alg: self-tests for polyval using polyval failed (rc=-2)
>
> Resolution:-
> Enabling CONFIG_CRYPTO_SM3_GENERIC, CONFIG_CRYPTO_SM4_GENERIC,
> CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables support of
> sm3, sm4, aria, polyval & xctr.
>
> Signed-off-by: Kshitiz Varshney <kshitiz.varshney@nxp.com>
This looks like an issue in tcrypt. When algorithms are unavailable it should
consider the corresponding test cases to be skipped, not failed.
> arch/arm/configs/imx_v6_v7_defconfig | 4 ++++
There should be no need to enable every crypto algorithm in every defconfig
file. Can you consider fixing the underlying issue instead of doing that?
- Eric
prev parent reply other threads:[~2024-02-05 20:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 11:29 [PATCH v2] Enable config for sm3, sm4, polyval, xctr cipher test as built in module Kshitiz Varshney
2024-02-05 20:19 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205201920.GA2220@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=V.Sethi@nxp.com \
--cc=festevam@gmail.com \
--cc=gaurav.jain@nxp.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel@pengutronix.de \
--cc=kshitiz.varshney@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=meenakshi.aggarwal@nxp.com \
--cc=nikhil.singla@nxp.com \
--cc=pankaj.gupta@nxp.com \
--cc=rahulkumar.yadav@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sahil.malhotra@nxp.com \
--cc=shawnguo@kernel.org \
--cc=vabhav.sharma@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox