* [PATCH] soundwire: bus_type: make sdw_bus_type const
@ 2024-02-13 14:36 Ricardo B. Marliere
2024-02-13 17:29 ` Greg Kroah-Hartman
2024-02-16 12:02 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Ricardo B. Marliere @ 2024-02-13 14:36 UTC (permalink / raw)
To: Vinod Koul, Bard Liao, Pierre-Louis Bossart, Sanyog Kale
Cc: alsa-devel, linux-kernel, Greg Kroah-Hartman, Ricardo B. Marliere
Since commit d492cc2573a0 ("driver core: device.h: make struct
bus_type a const *"), the driver core can properly handle constant
struct bus_type, move the sdw_bus_type variable to be a constant
structure as well, placing it into read-only memory which can not be
modified at runtime.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
drivers/soundwire/bus_type.c | 2 +-
include/linux/soundwire/sdw_type.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c
index 9fa93bb923d7..fd65b2360fc1 100644
--- a/drivers/soundwire/bus_type.c
+++ b/drivers/soundwire/bus_type.c
@@ -72,7 +72,7 @@ int sdw_slave_uevent(const struct device *dev, struct kobj_uevent_env *env)
return 0;
}
-struct bus_type sdw_bus_type = {
+const struct bus_type sdw_bus_type = {
.name = "soundwire",
.match = sdw_bus_match,
};
diff --git a/include/linux/soundwire/sdw_type.h b/include/linux/soundwire/sdw_type.h
index d8c27f1e5559..b445f7200f06 100644
--- a/include/linux/soundwire/sdw_type.h
+++ b/include/linux/soundwire/sdw_type.h
@@ -4,7 +4,7 @@
#ifndef __SOUNDWIRE_TYPES_H
#define __SOUNDWIRE_TYPES_H
-extern struct bus_type sdw_bus_type;
+extern const struct bus_type sdw_bus_type;
extern struct device_type sdw_slave_type;
extern struct device_type sdw_master_type;
---
base-commit: 9282cfa2eb080e3bbb95f488af35618b614cdf76
change-id: 20240213-bus_cleanup-soundwire-8b56c6862ef1
Best regards,
--
Ricardo B. Marliere <ricardo@marliere.net>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] soundwire: bus_type: make sdw_bus_type const
2024-02-13 14:36 [PATCH] soundwire: bus_type: make sdw_bus_type const Ricardo B. Marliere
@ 2024-02-13 17:29 ` Greg Kroah-Hartman
2024-02-16 12:02 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2024-02-13 17:29 UTC (permalink / raw)
To: Ricardo B. Marliere
Cc: Vinod Koul, Bard Liao, Pierre-Louis Bossart, Sanyog Kale,
alsa-devel, linux-kernel
On Tue, Feb 13, 2024 at 11:36:56AM -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct
> bus_type a const *"), the driver core can properly handle constant
> struct bus_type, move the sdw_bus_type variable to be a constant
> structure as well, placing it into read-only memory which can not be
> modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] soundwire: bus_type: make sdw_bus_type const
2024-02-13 14:36 [PATCH] soundwire: bus_type: make sdw_bus_type const Ricardo B. Marliere
2024-02-13 17:29 ` Greg Kroah-Hartman
@ 2024-02-16 12:02 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2024-02-16 12:02 UTC (permalink / raw)
To: Bard Liao, Pierre-Louis Bossart, Sanyog Kale, Ricardo B. Marliere
Cc: alsa-devel, linux-kernel, Greg Kroah-Hartman
On Tue, 13 Feb 2024 11:36:56 -0300, Ricardo B. Marliere wrote:
> Since commit d492cc2573a0 ("driver core: device.h: make struct
> bus_type a const *"), the driver core can properly handle constant
> struct bus_type, move the sdw_bus_type variable to be a constant
> structure as well, placing it into read-only memory which can not be
> modified at runtime.
>
>
> [...]
Applied, thanks!
[1/1] soundwire: bus_type: make sdw_bus_type const
commit: 81a7d0c4d059cb5c122110acbeec7bedfb91a741
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-16 12:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-13 14:36 [PATCH] soundwire: bus_type: make sdw_bus_type const Ricardo B. Marliere
2024-02-13 17:29 ` Greg Kroah-Hartman
2024-02-16 12:02 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox