From: Stefan Berger <stefanb@linux.ibm.com>
To: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
herbert@gondor.apana.org.au, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br,
Stefan Berger <stefanb@linux.ibm.com>
Subject: [PATCH v2 11/14] crypto: Add nbits field to ecc_curve structure
Date: Thu, 15 Feb 2024 18:14:10 -0500 [thread overview]
Message-ID: <20240215231414.3857320-12-stefanb@linux.ibm.com> (raw)
In-Reply-To: <20240215231414.3857320-1-stefanb@linux.ibm.com>
Add the number of bits a curve has to the ecc_curve definition. This field
only needs to be set for curves that don't fill up all bytes in their
digits, such as NIST P521 which has only 9 bits in the most significant
digit. This field will be used to determine the number of bytes a curve
requires for its key coordinates for example.
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
crypto/ecc_curve_defs.h | 1 +
include/crypto/ecc_curve.h | 3 +++
2 files changed, 4 insertions(+)
diff --git a/crypto/ecc_curve_defs.h b/crypto/ecc_curve_defs.h
index 93a47a5d460a..09a221657c31 100644
--- a/crypto/ecc_curve_defs.h
+++ b/crypto/ecc_curve_defs.h
@@ -119,6 +119,7 @@ static u64 nist_p521_b[] = { 0xef451fd46b503f00ull, 0x3573df883d2c34f1ull,
0x051ull };
static struct ecc_curve nist_p521 = {
.name = "nist_521",
+ .nbits = 521,
.g = {
.x = nist_p521_g_x,
.y = nist_p521_g_y,
diff --git a/include/crypto/ecc_curve.h b/include/crypto/ecc_curve.h
index 70964781eb68..337a44956926 100644
--- a/include/crypto/ecc_curve.h
+++ b/include/crypto/ecc_curve.h
@@ -23,6 +23,8 @@ struct ecc_point {
* struct ecc_curve - definition of elliptic curve
*
* @name: Short name of the curve.
+ * @nbits: Curves that do not use all bits in their ndigits must specify
+ * their number of bits here, otherwise can leave at 0.
* @g: Generator point of the curve.
* @p: Prime number, if Barrett's reduction is used for this curve
* pre-calculated value 'mu' is appended to the @p after ndigits.
@@ -34,6 +36,7 @@ struct ecc_point {
*/
struct ecc_curve {
char *name;
+ unsigned int nbits;
struct ecc_point g;
u64 *p;
u64 *n;
--
2.43.0
next prev parent reply other threads:[~2024-02-15 23:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 23:13 [PATCH v2 00/14] Add support for NIST P521 to ecdsa and ecdh Stefan Berger
2024-02-15 23:14 ` [PATCH v2 01/14] crypto: ecdsa - Convert byte arrays with key coordinates to digits Stefan Berger
2024-02-15 23:14 ` [PATCH v2 02/14] crypto: ecdsa - Adjust tests on length of key parameters Stefan Berger
2024-02-15 23:14 ` [PATCH v2 03/14] crypto: ecdsa - Extend res.x mod n calculation for NIST P521 Stefan Berger
2024-02-15 23:14 ` [PATCH v2 04/14] crypto: ecc - Implement vli_mmod_fast_521 for NIST p521 Stefan Berger
2024-02-15 23:14 ` [PATCH v2 05/14] crypto: ecc - For NIST P521 use vli_num_bits to get number of bits Stefan Berger
2024-02-15 23:14 ` [PATCH v2 06/14] crypto: ecc - Add NIST P521 curve parameters Stefan Berger
2024-02-16 18:48 ` Elliott, Robert (Servers)
2024-02-16 19:03 ` Stefan Berger
2024-02-15 23:14 ` [PATCH v2 07/14] crypto: ecdsa - Register NIST P521 and extend test suite Stefan Berger
2024-02-15 23:14 ` [PATCH v2 08/14] x509: Add OID for NIST P521 and extend parser for it Stefan Berger
2024-02-15 23:14 ` [PATCH v2 09/14] crypto: ecdh - Use properly formatted digits to check for valid key Stefan Berger
2024-02-15 23:14 ` [PATCH v2 10/14] crypto: ecc - Implement ecc_digits_to_bytes to convert digits to byte array Stefan Berger
2024-02-15 23:14 ` Stefan Berger [this message]
2024-02-15 23:14 ` [PATCH v2 12/14] crypto: ecc - Implement and use ecc_curve_get_nbytes to get curve's nbytes Stefan Berger
2024-02-15 23:14 ` [PATCH v2 13/14] crypto: ecdh - Use functions to copy digits from and to byte array Stefan Berger
2024-02-15 23:14 ` [PATCH v2 14/14] crypto: ecdh - Add support for NIST P521 and add test case Stefan Berger
2024-02-16 19:27 ` [PATCH v2 00/14] Add support for NIST P521 to ecdsa and ecdh Simo Sorce
2024-02-16 19:32 ` Stefan Berger
2024-02-16 19:40 ` Simo Sorce
2024-02-19 14:40 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215231414.3857320-12-stefanb@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saulo.alessandre@tse.jus.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox