From: Stefan Berger <stefanb@linux.ibm.com>
To: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
herbert@gondor.apana.org.au, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br,
Stefan Berger <stefanb@linux.ibm.com>
Subject: [PATCH v2 05/14] crypto: ecc - For NIST P521 use vli_num_bits to get number of bits
Date: Thu, 15 Feb 2024 18:14:04 -0500 [thread overview]
Message-ID: <20240215231414.3857320-6-stefanb@linux.ibm.com> (raw)
In-Reply-To: <20240215231414.3857320-1-stefanb@linux.ibm.com>
In ecc_point_mult use vli_num_bits to determine the number of bits when
using NIST P521. The change is required specifically for NIST P521 to
pass mathematical tests on the public key.
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
crypto/ecc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/crypto/ecc.c b/crypto/ecc.c
index ea7b28b5e00e..0734cea284a4 100644
--- a/crypto/ecc.c
+++ b/crypto/ecc.c
@@ -1326,7 +1326,10 @@ static void ecc_point_mult(struct ecc_point *result,
carry = vli_add(sk[0], scalar, curve->n, ndigits);
vli_add(sk[1], sk[0], curve->n, ndigits);
scalar = sk[!carry];
- num_bits = sizeof(u64) * ndigits * 8 + 1;
+ if (ndigits == 9 && !strcmp(curve->name, "nist_521"))
+ num_bits = vli_num_bits(scalar, ndigits);
+ else
+ num_bits = sizeof(u64) * ndigits * 8 + 1;
vli_set(rx[1], point->x, ndigits);
vli_set(ry[1], point->y, ndigits);
--
2.43.0
next prev parent reply other threads:[~2024-02-15 23:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 23:13 [PATCH v2 00/14] Add support for NIST P521 to ecdsa and ecdh Stefan Berger
2024-02-15 23:14 ` [PATCH v2 01/14] crypto: ecdsa - Convert byte arrays with key coordinates to digits Stefan Berger
2024-02-15 23:14 ` [PATCH v2 02/14] crypto: ecdsa - Adjust tests on length of key parameters Stefan Berger
2024-02-15 23:14 ` [PATCH v2 03/14] crypto: ecdsa - Extend res.x mod n calculation for NIST P521 Stefan Berger
2024-02-15 23:14 ` [PATCH v2 04/14] crypto: ecc - Implement vli_mmod_fast_521 for NIST p521 Stefan Berger
2024-02-15 23:14 ` Stefan Berger [this message]
2024-02-15 23:14 ` [PATCH v2 06/14] crypto: ecc - Add NIST P521 curve parameters Stefan Berger
2024-02-16 18:48 ` Elliott, Robert (Servers)
2024-02-16 19:03 ` Stefan Berger
2024-02-15 23:14 ` [PATCH v2 07/14] crypto: ecdsa - Register NIST P521 and extend test suite Stefan Berger
2024-02-15 23:14 ` [PATCH v2 08/14] x509: Add OID for NIST P521 and extend parser for it Stefan Berger
2024-02-15 23:14 ` [PATCH v2 09/14] crypto: ecdh - Use properly formatted digits to check for valid key Stefan Berger
2024-02-15 23:14 ` [PATCH v2 10/14] crypto: ecc - Implement ecc_digits_to_bytes to convert digits to byte array Stefan Berger
2024-02-15 23:14 ` [PATCH v2 11/14] crypto: Add nbits field to ecc_curve structure Stefan Berger
2024-02-15 23:14 ` [PATCH v2 12/14] crypto: ecc - Implement and use ecc_curve_get_nbytes to get curve's nbytes Stefan Berger
2024-02-15 23:14 ` [PATCH v2 13/14] crypto: ecdh - Use functions to copy digits from and to byte array Stefan Berger
2024-02-15 23:14 ` [PATCH v2 14/14] crypto: ecdh - Add support for NIST P521 and add test case Stefan Berger
2024-02-16 19:27 ` [PATCH v2 00/14] Add support for NIST P521 to ecdsa and ecdh Simo Sorce
2024-02-16 19:32 ` Stefan Berger
2024-02-16 19:40 ` Simo Sorce
2024-02-19 14:40 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215231414.3857320-6-stefanb@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saulo.alessandre@tse.jus.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox