From: Shahar Avidar <ikobh7@gmail.com>
To: gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl,
andriy.shevchenko@linux.intel.com, robh@kernel.org,
felixkimbu1@gmail.com
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/6] staging: pi433: Rename struct pi433_device buffer field to tx_buffer.
Date: Tue, 2 Apr 2024 14:14:09 +0300 [thread overview]
Message-ID: <20240402111414.871089-2-ikobh7@gmail.com> (raw)
In-Reply-To: <20240402111414.871089-1-ikobh7@gmail.com>
Driver holds buffers in different structs, as does the HW.
Using explicit names for buffers increases readability.
Signed-off-by: Shahar Avidar <ikobh7@gmail.com>
---
drivers/staging/pi433/pi433_if.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 8c513ac62156..13b464ab7db8 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -90,7 +90,7 @@ struct pi433_device {
struct task_struct *tx_task_struct;
wait_queue_head_t tx_wait_queue;
u8 free_in_fifo;
- char buffer[MAX_MSG_SIZE];
+ char tx_buffer[MAX_MSG_SIZE];
/* rx related values */
struct pi433_rx_cfg rx_cfg;
@@ -613,8 +613,8 @@ static int pi433_tx_thread(void *data)
if (tx_cfg.enable_address_byte == OPTION_ON)
size++;
- /* prime buffer */
- memset(device->buffer, 0, size);
+ /* prime tx_buffer */
+ memset(device->tx_buffer, 0, size);
position = 0;
/* add length byte, if requested */
@@ -623,15 +623,15 @@ static int pi433_tx_thread(void *data)
* according to spec, length byte itself must be
* excluded from the length calculation
*/
- device->buffer[position++] = size - 1;
+ device->tx_buffer[position++] = size - 1;
/* add adr byte, if requested */
if (tx_cfg.enable_address_byte == OPTION_ON)
- device->buffer[position++] = tx_cfg.address_byte;
+ device->tx_buffer[position++] = tx_cfg.address_byte;
/* finally get message data from fifo */
- retval = kfifo_out(&device->tx_fifo, &device->buffer[position],
- sizeof(device->buffer) - position);
+ retval = kfifo_out(&device->tx_fifo, &device->tx_buffer[position],
+ sizeof(device->tx_buffer) - position);
dev_dbg(device->dev,
"read %d message byte(s) from fifo queue.\n", retval);
@@ -715,7 +715,7 @@ static int pi433_tx_thread(void *data)
device->free_in_fifo = 0;
rf69_write_fifo(spi,
- &device->buffer[position],
+ &device->tx_buffer[position],
write_size);
position += write_size;
} else {
@@ -723,7 +723,7 @@ static int pi433_tx_thread(void *data)
device->free_in_fifo -= size;
repetitions--;
rf69_write_fifo(spi,
- &device->buffer[position],
+ &device->tx_buffer[position],
(size - position));
position = 0; /* reset for next repetition */
}
--
2.34.1
next prev parent reply other threads:[~2024-04-02 11:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 11:14 [PATCH v2 0/6] staging: pi433: Remove duplicated code using the "goto" error recovery scheme Shahar Avidar
2024-04-02 11:14 ` Shahar Avidar [this message]
2024-04-02 11:14 ` [PATCH v2 2/6] staging: pi433: Rename struct pi433_device instances to pi433 Shahar Avidar
2024-04-02 11:14 ` [PATCH v2 3/6] staging: pi433: Replace pi433_receive param void type to struct pi433_device Shahar Avidar
2024-04-02 11:14 ` [PATCH v2 4/6] staging: pi433: Rename "pi433_dev" of type "dev_t" to "pi433_devt" Shahar Avidar
2024-04-02 11:14 ` [PATCH v2 5/6] staging: pi433: Remove duplicated code using the "goto" error recovery scheme Shahar Avidar
2024-04-02 16:46 ` Dan Carpenter
2024-04-05 7:46 ` Shahar Avidar
2024-04-02 11:14 ` [PATCH v2 6/6] staging: pi433: Rename return value from "status" to "ret" Shahar Avidar
2024-04-02 16:50 ` Dan Carpenter
2024-04-05 7:47 ` Shahar Avidar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402111414.871089-2-ikobh7@gmail.com \
--to=ikobh7@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=felixkimbu1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox