public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shahar Avidar <ikobh7@gmail.com>
To: gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl,
	andriy.shevchenko@linux.intel.com, robh@kernel.org,
	felixkimbu1@gmail.com
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 6/6] staging: pi433: Rename return value from "status" to "ret".
Date: Tue,  2 Apr 2024 14:14:14 +0300	[thread overview]
Message-ID: <20240402111414.871089-7-ikobh7@gmail.com> (raw)
In-Reply-To: <20240402111414.871089-1-ikobh7@gmail.com>

Drivers init functions usually use either "ret" or "rc" naming their
return variable.

Signed-off-by: Shahar Avidar <ikobh7@gmail.com>
---
 drivers/staging/pi433/pi433_if.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 47e0c51ffe2e..b0407d5c6be8 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -1384,7 +1384,7 @@ static struct spi_driver pi433_spi_driver = {
 
 static int __init pi433_init(void)
 {
-	int status;
+	int ret;
 
 	/*
 	 * If MAX_MSG_SIZE is smaller then FIFO_SIZE, the driver won't
@@ -1398,21 +1398,21 @@ static int __init pi433_init(void)
 	 * that will key udev/mdev to add/remove /dev nodes.
 	 * Last, register the driver which manages those device numbers.
 	 */
-	status = alloc_chrdev_region(&pi433_devt, 0, N_PI433_MINORS, "pi433");
-	if (status)
-		return status;
+	ret = alloc_chrdev_region(&pi433_devt, 0, N_PI433_MINORS, "pi433");
+	if (ret)
+		return ret;
 
-	status = class_register(&pi433_class);
-	if (status)
+	ret = class_register(&pi433_class);
+	if (ret)
 		goto unreg_chrdev;
 
-	status = spi_register_driver(&pi433_spi_driver);
-	if (status)
+	ret = spi_register_driver(&pi433_spi_driver);
+	if (ret)
 		goto unreg_class;
 
 	root_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
 	if (IS_ERR(root_dir)) {
-		status = PTR_ERR(root_dir);
+		ret = PTR_ERR(root_dir);
 		goto unreg_spi_drv;
 	}
 
@@ -1425,7 +1425,7 @@ static int __init pi433_init(void)
 unreg_chrdev:
 	unregister_chrdev(MAJOR(pi433_devt), pi433_spi_driver.driver.name);
 
-	return status;
+	return ret;
 }
 
 module_init(pi433_init);
-- 
2.34.1


  parent reply	other threads:[~2024-04-02 11:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 11:14 [PATCH v2 0/6] staging: pi433: Remove duplicated code using the "goto" error recovery scheme Shahar Avidar
2024-04-02 11:14 ` [PATCH v2 1/6] staging: pi433: Rename struct pi433_device buffer field to tx_buffer Shahar Avidar
2024-04-02 11:14 ` [PATCH v2 2/6] staging: pi433: Rename struct pi433_device instances to pi433 Shahar Avidar
2024-04-02 11:14 ` [PATCH v2 3/6] staging: pi433: Replace pi433_receive param void type to struct pi433_device Shahar Avidar
2024-04-02 11:14 ` [PATCH v2 4/6] staging: pi433: Rename "pi433_dev" of type "dev_t" to "pi433_devt" Shahar Avidar
2024-04-02 11:14 ` [PATCH v2 5/6] staging: pi433: Remove duplicated code using the "goto" error recovery scheme Shahar Avidar
2024-04-02 16:46   ` Dan Carpenter
2024-04-05  7:46     ` Shahar Avidar
2024-04-02 11:14 ` Shahar Avidar [this message]
2024-04-02 16:50   ` [PATCH v2 6/6] staging: pi433: Rename return value from "status" to "ret" Dan Carpenter
2024-04-05  7:47     ` Shahar Avidar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240402111414.871089-7-ikobh7@gmail.com \
    --to=ikobh7@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=felixkimbu1@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox