From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: "Lijo Lazar" <lijo.lazar@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Asad Kamal" <asad.kamal@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Sasha Levin" <sashal@kernel.org>,
Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
ltuikov89@gmail.com, dakr@redhat.com, zhenguo.yin@amd.com,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [PATCH AUTOSEL 6.1 14/19] drm/amdgpu: Refine IB schedule error logging
Date: Mon, 22 Apr 2024 19:18:28 -0400 [thread overview]
Message-ID: <20240422231845.1607921-14-sashal@kernel.org> (raw)
In-Reply-To: <20240422231845.1607921-1-sashal@kernel.org>
From: Lijo Lazar <lijo.lazar@amd.com>
[ Upstream commit 4b18a91faf1752f9bd69a4ed3aed2c8f6e5b0528 ]
Downgrade to debug information when IBs are skipped. Also, use dev_* to
identify the device.
Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Asad Kamal <asad.kamal@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
index 3bf0e893c07df..f34bc9bb7045a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
@@ -301,12 +301,15 @@ static struct dma_fence *amdgpu_job_run(struct drm_sched_job *sched_job)
dma_fence_set_error(finished, -ECANCELED);
if (finished->error < 0) {
- DRM_INFO("Skip scheduling IBs!\n");
+ dev_dbg(adev->dev, "Skip scheduling IBs in ring(%s)",
+ ring->name);
} else {
r = amdgpu_ib_schedule(ring, job->num_ibs, job->ibs, job,
&fence);
if (r)
- DRM_ERROR("Error scheduling IBs (%d)\n", r);
+ dev_err(adev->dev,
+ "Error scheduling IBs (%d) in ring(%s)", r,
+ ring->name);
}
job->job_run_counter++;
--
2.43.0
next prev parent reply other threads:[~2024-04-22 23:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 23:18 [PATCH AUTOSEL 6.1 01/19] tools/power turbostat: Fix added raw MSR output Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 02/19] tools/power turbostat: Increase the limit for fd opened Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 03/19] tools/power turbostat: Fix Bzy_MHz documentation typo Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 04/19] btrfs: make btrfs_clear_delalloc_extent() free delalloc reserve Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 05/19] btrfs: always clear PERTRANS metadata during commit Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 06/19] memblock tests: fix undefined reference to `early_pfn_to_nid' Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 07/19] memblock tests: fix undefined reference to `panic' Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 08/19] memblock tests: fix undefined reference to `BIT' Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 09/19] scsi: target: Fix SELinux error when systemd-modules loads the target module Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 10/19] blk-iocost: avoid out of bounds shift Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 11/19] gpu: host1x: Do not setup DMA for virtual devices Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 12/19] MIPS: scall: Save thread_info.syscall unconditionally on entry Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 13/19] tools/power/turbostat: Fix uncore frequency file string Sasha Levin
2024-04-22 23:18 ` Sasha Levin [this message]
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 15/19] selftests: timers: Fix valid-adjtimex signed left-shift undefined behavior Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 16/19] Drivers: hv: vmbus: Track decrypted status in vmbus_gpadl Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 17/19] uio_hv_generic: Don't free decrypted memory Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 18/19] Drivers: hv: vmbus: Don't free ring buffers that couldn't be re-encrypted Sasha Levin
2024-04-22 23:18 ` [PATCH AUTOSEL 6.1 19/19] iommu: mtk: fix module autoloading Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240422231845.1607921-14-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=asad.kamal@amd.com \
--cc=christian.koenig@amd.com \
--cc=dakr@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=lijo.lazar@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ltuikov89@gmail.com \
--cc=stable@vger.kernel.org \
--cc=zhenguo.yin@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox